chore(): lean only on firebase types and compatibility with 5.0.4 - #1729
Merged
Conversation
Contributor
Author
|
@davideast going to check on more regressions with SSR + put a test in; may have some follow on commits w/ changelog entries on this PR. That said, it seems a low risk bump that I want to get out ASAP due to 5.0.4, so I'll see what I get done before you have a chance to review. Sorry for the delay here. |
Contributor
|
can you check this error out sir ? maybe we can make an small update for this error in 5.0-RC-11 too. the firebase make some update and that logger tell me to update code because |
Contributor
|
Wondering what the status is on this commit. My application does not serve and this commit seems to have fixed the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
firebase/*which are pulled in from@firebase/*-typeshence unstable, now using the more verbose but publicfirebasetypesappsandinitializeAppfromfirebase/appis reaching through to@firebase/appwhich isn't stable (and the exports aren't available in all the entry-points). Again here use the publicfirebase.appsandfirebase.initializeApp. Angular 6 SSR build issue #1705<any>s in there to make our build green, rather than rehauling our types due to the breaks in 5.0.4.Added a
5.0.0-rc.11changelog entry and updated the package.json so I can tag + cut immediately once approved.