Skip to content

chore(): rc.10 - #1679

Merged
davideast merged 1 commit into
masterfrom
rc10
May 22, 2018
Merged

chore(): rc.10#1679
davideast merged 1 commit into
masterfrom
rc10

Conversation

@jamesdaniels

@jamesdaniels jamesdaniels commented May 22, 2018

Copy link
Copy Markdown
Contributor

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

@jamesdaniels
jamesdaniels requested a review from davideast May 22, 2018 16:59
davideast
davideast approved these changes May 22, 2018
View reviewed changes

@davideast davideast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davideast
davideast merged commit a42a84f into master May 22, 2018
@jamesdaniels
jamesdaniels deleted the rc10 branch May 22, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davideast davideast davideast approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesdaniels @davideast @googlebot