This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(*): clean up package.json and CircleCI config - #17034
Merged
Conversation
Contributor
|
Why two PRs? This and #17033 |
Member
Author
|
I am testing some stuff. (Still drafts - no need to review yet 😁) |
This is a follow-up to angular#16915, cleaning up `package.json` and `.circleci/config.yml` and making release scripts executable.
gkalpak
marked this pull request as ready for review
May 25, 2020 12:20
petebacondarwin
approved these changes
May 25, 2020
petebacondarwin
left a comment
Contributor
There was a problem hiding this comment.
Awesome - thanks for watching my back @gkalpak.
OOC where do you find the SHAs for the docker images?
| @@ -1,4 +1,4 @@ | |||
| # Configuration file for https://circleci.com/gh/angular/angular | |||
| # Configuration file for https://circleci.com/gh/angular/angular.js | |||
Member
Author
|
🤜🤛 The easiest way to find the SHA (that I know of) is to let the job run and look at the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #16915, cleaning up
package.jsonand.circleci/config.ymland making release scripts executable.