docs: Adds HTTP communication guidance to Angular Skills by SkyZeroZx · Pull Request #69645 · angular/angular

SkyZeroZx · 2026-07-04T17:38:19Z

SkyZeroZx · 2026-07-04T17:39:46Z

+- Calling `provideHttpClient()` with no features is not required for basic HTTP requests, but it configures the default HTTP feature set for that injector, including Angular's XSRF interceptor.
+- Prefer `provideHttpClient(...)` over `HttpClientModule` for feature configuration, especially with multiple injectors.
+- Use `withRequestsMadeViaParent()` when a child injector should add interceptors while still delegating to the parent HTTP chain.
+- Prefer CORS over JSONP. Use `withJsonpSupport()` only for legacy APIs that require JSONP.


In fact, I think we should avoid mentioning or directly say never to use JsonP because of the risk of XSS. Or should we still leave it as legacy support?

Yeah, let's just remove any mention of JSONP. It belongs in the past.

Wouldn't it be better to emphasize not using it (I say this to avoid confusion or to provide better guidance for the agents)?

Since, for example, if I start a new project (even with Angular skills) it adds withFetch for some reason when there's an unrelated problem, I would assume this might happen unexpectedly with JsonP

EDIT: According to GTP 5.5 using skill-creator, it indicates that it would be better to omit it, so let's go with that option.

I would really be surprised if agents would even suggest it. It's really an old tech that isn't used anymore.

dominicbachmann

What do you think about also adding examples of how to test this, as described in https://angular.dev/guide/http/testing?

dominicbachmann · 2026-07-06T06:50:38Z

+import {input} from '@angular/core';
+
+export class UserProfile {
+  userId = input.required<string>();


The HttpClient example above uses modifiers like private and readonly. Is there a particular reason they're not used here? Otherwise I'd keep the examples consistent

The HttpClient example above uses modifiers like private and readonly. Is there a particular reason they're not used here? Otherwise I'd keep the examples consistent

I agree, it should be consistent.

What do you think about also adding examples of how to test this, as described in angular.dev/guide/http/testing?

I'm not sure if we should add testing to this guide because we might have context that would consume more tokens for our agent. I believe everything related to testing should be a separate skill, and it would also be called as required by the user prompt.

dominicbachmann · 2026-07-06T21:25:23Z

 - **Component Harnesses**: Standard patterns for robust component interaction. Read [component-harnesses.md](references/component-harnesses.md)
 - **Router Testing**: Using `RouterTestingHarness` for reliable navigation tests. Read [router-testing.md](references/router-testing.md)
 - **End-to-End (E2E) Testing**: Best practices for E2E tests with Cypress. Read [e2e-testing.md](references/e2e-testing.md)



@SkyZeroZx What do you think about adding a http testing reference here?

Yes, that makes sense, but I think it would be better to address it in a follow-up PR to avoid adding extra overhead to this one.

Personally I would add to this PR. Let's see what the others think.

JeanMeche · 2026-07-05T17:44:31Z

+
+Important rules:
+
+- `HttpClient` requests are cold `Observable`s. No request is sent until something subscribes. Multiple subscriptions send multiple backend requests.


Suggested change

- `HttpClient` requests are cold `Observable`s. No request is sent until something subscribes. Multiple subscriptions send multiple backend requests.

- `HttpClient` requests are cold `Observable`s. No request is sent until the `Observable` is subscribed to. Multiple subscriptions send multiple backend requests.

JeanMeche · 2026-07-05T17:49:09Z

+
+## `httpResource`
+
+Use `httpResource` for reactive reads that should expose request status and value as signals.


I think this sentence could be improved.
httpResource isn't just reactive reads:

it's an async derivation

it fetchs over http

it is indeed reactive, via the signal it exposes.

I hadn't seen it, it's been updated right now

JeanMeche · 2026-07-05T17:50:45Z

+- Calling `provideHttpClient()` with no features is not required for basic HTTP requests, but it configures the default HTTP feature set for that injector, including Angular's XSRF interceptor.
+- Prefer `provideHttpClient(...)` over `HttpClientModule` for feature configuration, especially with multiple injectors.
+- Use `withRequestsMadeViaParent()` when a child injector should add interceptors while still delegating to the parent HTTP chain.
+- Prefer CORS over JSONP. Use `withJsonpSupport()` only for legacy APIs that require JSONP.


I would really be surprised if agents would even suggest it. It's really an old tech that isn't used anymore.

pkozlowski-opensource · 2026-07-22T13:29:27Z

There are failing lint checks, see: https://github.com/angular/angular/actions/runs/29865635531/job/88886764693?pr=69645

SkyZeroZx · 2026-07-23T18:27:10Z

There are failing lint checks, see: angular/angular/actions/runs/29865635531/job/88886764693?pr=69645

It's updated, I think we could merge

alxhub · 2026-07-29T15:37:22Z

This PR was merged into the repository. The changes were merged into the following branches:

main: 840f071
22.0.x: 8acc4db
22.1.x: 5496765

pullapprove Bot requested a review from kirjs July 4, 2026 17:38

angular-robot Bot added the area: docs Related to the documentation label Jul 4, 2026

ngbot Bot added this to the Backlog milestone Jul 4, 2026

SkyZeroZx commented Jul 4, 2026

View reviewed changes

eneajaho reviewed Jul 4, 2026

View reviewed changes

Comment thread skills/dev-skills/angular-developer/references/http-client.md

dominicbachmann reviewed Jul 6, 2026

View reviewed changes

SkyZeroZx requested a review from dominicbachmann July 6, 2026 19:00

SkyZeroZx force-pushed the skills/http-skill branch from ad636c9 to a5372ee Compare July 6, 2026 19:01

dominicbachmann reviewed Jul 6, 2026

View reviewed changes

SkyZeroZx force-pushed the skills/http-skill branch from a5372ee to 8ed3d3d Compare July 7, 2026 05:31

JeanMeche approved these changes Jul 21, 2026

View reviewed changes

JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 21, 2026

JeanMeche removed the request for review from kirjs July 21, 2026 20:13

angular-robot Bot requested a review from JeanMeche July 21, 2026 20:25

pkozlowski-opensource added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jul 22, 2026

SkyZeroZx added 2 commits July 22, 2026 09:15

docs: Adds HTTP communication guidance to Angular Skills

dd4b302

fixup! docs: Adds HTTP communication guidance to Angular Skills

104b5f6

SkyZeroZx force-pushed the skills/http-skill branch from fe6a04b to 104b5f6 Compare July 22, 2026 14:16

JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 23, 2026

JeanMeche approved these changes Jul 26, 2026

View reviewed changes

alxhub merged commit 840f071 into angular:main Jul 29, 2026
25 checks passed


		Important rules:

		- `HttpClient` requests are cold `Observable`s. No request is sent until something subscribes. Multiple subscriptions send multiple backend requests.


		## `httpResource`

		Use `httpResource` for reactive reads that should expose request status and value as signals.

Uh oh!

Conversation

SkyZeroZx commented Jul 4, 2026

Uh oh!

SkyZeroZx Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SkyZeroZx Jul 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dominicbachmann left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pkozlowski-opensource commented Jul 22, 2026

Uh oh!

SkyZeroZx commented Jul 23, 2026

Uh oh!

Uh oh!

alxhub commented Jul 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SkyZeroZx Jul 4, 2026 •

edited

Loading

SkyZeroZx Jul 5, 2026 •

edited

Loading