fix(docs-infra): center social and theme menus under their triggers o…#69340
Open
erkamyaman wants to merge 1 commit into
Open
fix(docs-infra): center social and theme menus under their triggers o…#69340erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
…n tablet On tablet the social and theme mini-menus didn't line up with the buttons that open them. All three mini-menus now share one tablet positioning rule on `.adev-mini-menu` that centers each panel under its trigger, with `--social`/`--theme`/`--version` modifiers selecting the anchor; the version picker's on-screen behavior is unchanged. The social trigger also gains `aria-controls` + a matching menu `id` for a11y parity with the theme trigger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On tablet the social and theme mini-menus shared a fixed
top/leftoffset, so their dropdowns didn't line up with the buttons that open them.They now anchor to their triggers and center beneath them via the same CSS anchor positioning the version picker uses. The social trigger also gains
aria-controls+ a matching menuidfor a11y parity with the theme trigger.PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On tablet widths (701–900px), the social-links and theme-picker mini-menus were positioned with a fixed
top: 75px; left: 5pxoffset, so their dropdown panels did not line up with the buttons that open them.What is the new behavior?
The social and theme dropdowns now anchor to their trigger buttons and center beneath them on tablet, using the same CSS anchor positioning the version picker already used. The shared tablet positioning is consolidated onto
.adev-mini-menu, with--social/--theme/--versionmodifiers selecting each trigger, so all three mini-menus share one rule. The version picker's on-screen behavior is unchanged. The social trigger also gainsaria-controlsand a matching menuid, bringing it to accessibility parity with the theme trigger.Does this PR introduce a breaking change?