refactor(compiler): Collect in-element comments#69218
Open
JeanMeche wants to merge 1 commit into
Open
Conversation
b523b73 to
6ed063d
Compare
6ed063d to
6ec869d
Compare
JoostK
reviewed
Jun 10, 2026
6ec869d to
2d44f75
Compare
JoostK
reviewed
Jun 10, 2026
JoostK
left a comment
Member
There was a problem hiding this comment.
The comments also apply to the multiline parsing, of course
2d44f75 to
0ea4cdb
Compare
JoostK
reviewed
Jun 10, 2026
Comment on lines
+815
to
+825
| const commentStart = 0; | ||
| const commentEnd = content.length; | ||
| const spanStart = contentStart.clone(); | ||
| for (let i = 0; i < commentStart; i++) { | ||
| spanStart.advance(); | ||
| } | ||
|
|
||
| const spanEnd = contentStart.clone(); | ||
| for (let i = 0; i < commentEnd; i++) { | ||
| spanEnd.advance(); | ||
| } |
Member
There was a problem hiding this comment.
I don't think this is really necessary. spanStart is guaranteed to be contentStart as commentStart is always 0, and commentEnd is probably better achieved by subtracting the */ span (for multiline, singleline remains the end itself) instead of walking over all comment text.
PR angular#67179 forgot to implement that part.
0ea4cdb to
997a23b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#67179 forgot to implement that part.