fix(core): treat iframe credentialless as security-sensitive#69202
Open
SkyZeroZx wants to merge 1 commit into
Open
fix(core): treat iframe credentialless as security-sensitive#69202SkyZeroZx wants to merge 1 commit into
SkyZeroZx wants to merge 1 commit into
Conversation
credentialless iframe attribute to security schema332d014 to
76b7d6c
Compare
Contributor
|
//cc @securityMB from ISE to verify if we should do this. |
Yes, I think this change makes sense and the behavior of |
alan-agius4
approved these changes
Jun 8, 2026
alan-agius4
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: fw-security
JeanMeche
approved these changes
Jun 8, 2026
josephperrott
approved these changes
Jun 11, 2026
josephperrott
left a comment
Member
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-security
Mark the iframe `credentialless` attribute as security-sensitive so dynamic bindings are handled consistently with other iframe attributes that affect the initial navigation, such as `sandbox`, `allow`, `referrerPolicy`, `csp`, and `fetchPriority`. Because `credentialless` must be present before the iframe starts loading to affect the navigation’s credential mode, late dynamic updates can leave the final DOM looking correct while the initial request was not loaded credentiallessly.
76b7d6c to
7c5824b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the iframe
credentiallessattribute as security-sensitive so dynamicbindings are handled consistently with other iframe attributes that affect the
initial navigation, such as
sandbox,allow,referrerPolicy,csp, andfetchPriority.Because
credentiallessmust be present before the iframe starts loading toaffect the navigation’s credential mode, late dynamic updates can leave the final
DOM looking correct while the initial request was not loaded credentiallessly.