fix(compiler): add entries to the Trusted type sink. - #69050
Closed
JeanMeche wants to merge 1 commit into
Closed
Conversation
To prevent any non-safe i18n assignements, we add `base|href`, `frame|src` and `link|href` to the Trusted Type sink.
JeanMeche
marked this pull request as ready for review
June 1, 2026 15:08
alan-agius4
reviewed
Jun 1, 2026
alan-agius4
left a comment
Contributor
There was a problem hiding this comment.
Don鈥檛 these values already get sanitizer?
Also, the newly added elements are not part of the Trusted Sinks API AFAIK.
I don鈥檛 really know the history for added the Trusted Types, but I suspect it was due to the santizer was not integrated in the i18n pipeline before.
Contributor
|
cc @dgp1130 |
Member
Author
|
The root issue was already fixed by #68591 |
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent any non-safe i18n assignements, we add
base|href,frame|srcandlink|hrefto the Trusted Type sink.