refactor(compiler): emit instructions for foreign components#68786
Merged
Conversation
2cd45b5 to
6824070
Compare
When a template element matches an imported foreign component, the compiler omits standard element instructions (`ɵɵelementStart`/`ɵɵelement`) and instead generates a single `ɵɵforeignComponent` call. The call passes the exact foreign import wrapper expression defined in `@Component.foreignImports` along with an aggregated object literal containing all static attributes and property bindings. The instruction itself is currently a no-op.
6824070 to
b26fc24
Compare
JeanMeche
reviewed
May 20, 2026
JeanMeche
reviewed
May 20, 2026
atscott
reviewed
May 21, 2026
atscott
approved these changes
May 21, 2026
b486e4d to
d941c13
Compare
atscott
approved these changes
May 22, 2026
mattrbeck
approved these changes
May 23, 2026
Contributor
Author
|
Note for caretaker: TAP is green: cl/919726574. |
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a template element matches an imported foreign component, the compiler omits standard element instructions (
ɵɵelementStart/ɵɵelement) and instead generates a singleɵɵforeignComponentcall. The call passes the exact foreign import wrapper expression defined in@Component.foreignImportsalong with an aggregated object literal containing all static attributes and property bindings.The instruction itself is currently a no-op.