Skip to content

fix(compiler): disallow static i18n url attributes (XSS) #68557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hexix23 wants to merge 1 commit into from
Closed

fix(compiler): disallow static i18n url attributes (XSS) #68557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 38 additions & 7 deletions packages/compiler/src/render3/view/i18n/meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ import * as i18n from '../../../i18n/i18n_ast';
import {createI18nMessageFactory, VisitNodeFn} from '../../../i18n/i18n_parser';
import * as html from '../../../ml_parser/ast';
import {ParseTreeResult} from '../../../ml_parser/parser';
import {splitNsName} from '../../../ml_parser/tags';
import {TokenType} from '../../../ml_parser/tokens';
import * as o from '../../../output/output_ast';
import {SecurityContext} from '../../../core';
import {DomElementSchemaRegistry} from '../../../schema/dom_element_schema_registry';
import {isTrustedTypesSink} from '../../../schema/trusted_types_sinks';

import {hasI18nAttrs, I18N_ATTR, I18N_ATTR_PREFIX, icuFromI18nMessage} from './util';
Expand Down Expand Up @@ -49,6 +53,29 @@ const setI18nRefs = (originalNodeMap: Map<html.Node, html.Node>): VisitNodeFn =>
};
};

const domSchema = new DomElementSchemaRegistry();

function getElementName(node: html.Element | html.Component): string | null {
const tagName = node instanceof html.Component ? node.tagName : node.name;
return tagName === null ? null : splitNsName(tagName)[1];
}

function isStaticAttributeValue(attr: html.Attribute): boolean {
return !attr.valueTokens?.some((token) => token.type === TokenType.ATTR_VALUE_INTERPOLATION);
}

function isStaticUrlAttribute(node: html.Element | html.Component, attr: html.Attribute): boolean {
const elementName = getElementName(node);
if (elementName === null) {
return false;
}

return (
isStaticAttributeValue(attr) &&
domSchema.securityContext(elementName, attr.name, true) === SecurityContext.URL
);
}

/**
* This visitor walks over HTML parse tree and converts information stored in
* i18n-related attributes ("i18n" and "i18n-*") into i18n meta object that is
Expand Down Expand Up @@ -201,12 +228,9 @@ export class I18nMetaVisitor implements html.Visitor {
} else if (attr.name.startsWith(I18N_ATTR_PREFIX)) {
// 'i18n-*' attributes
const name = attr.name.slice(I18N_ATTR_PREFIX.length);
let isTrustedType: boolean;
if (node instanceof html.Component) {
isTrustedType = node.tagName === null ? false : isTrustedTypesSink(node.tagName, name);
} else {
isTrustedType = isTrustedTypesSink(node.name, name);
}
const elementName = getElementName(node);
const isTrustedType =
elementName === null ? false : isTrustedTypesSink(elementName, name);

if (isTrustedType) {
this._reportError(
Expand All @@ -228,7 +252,14 @@ export class I18nMetaVisitor implements html.Visitor {
const meta = attrsMeta[attr.name];
// do not create translation for empty attributes
if (meta !== undefined && attr.value) {
attr.i18n = this._generateI18nMessage([attr], attr.i18n || meta);
if (isStaticUrlAttribute(node, attr)) {
this._reportError(
attr,
`Translating attribute '${attr.name}' is disallowed for security reasons.`,
);
} else {
attr.i18n = this._generateI18nMessage([attr], attr.i18n || meta);
}
}
}
}
Expand Down
18 changes: 18 additions & 0 deletions packages/core/test/linker/security_integration_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,5 +273,23 @@ describe('security integration tests', function () {
/Translating attribute 'innerHTML' is disallowed for security reasons./,
);
});

it('should throw error on static URL attributes', () => {
const template = `<a href="/safe" i18n-href>Link</a>`;
TestBed.overrideComponent(SecuredComponent, {set: {template}});

expect(() => TestBed.createComponent(SecuredComponent)).toThrowError(
/Translating attribute 'href' is disallowed for security reasons./,
);
});

it('should throw error on static form action attributes', () => {
const template = `<form action="/safe" i18n-action></form>`;
TestBed.overrideComponent(SecuredComponent, {set: {template}});

expect(() => TestBed.createComponent(SecuredComponent)).toThrowError(
/Translating attribute 'action' is disallowed for security reasons./,
);
});
});
});
Loading