Skip to content

feat(migrations): Disabling nullishCoalescingNotNullable & optionalChainNotNullable on ng update - #68080

Merged
kirjs merged 1 commit into
angular:mainfrom
aparzi:migration-strict-safe-navigation-narrow
Apr 13, 2026
Merged

feat(migrations): Disabling nullishCoalescingNotNullable & optionalChainNotNullable on ng update#68080
kirjs merged 1 commit into
angular:mainfrom
aparzi:migration-strict-safe-navigation-narrow

Conversation

@aparzi

@aparzi aparzi commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Related to #67959 disabling two diagnostics errors by ng update:

  • nullishCoalescingNotNullable
  • optionalChainNotNullable

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

Disabling nullishCoalescingNotNullable & optionalChainNotNullable on ng update

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove
pullapprove Bot requested a review from JeanMeche April 8, 2026 12:58
@aparzi aparzi changed the title feat(migrations): Disabling nullishCoalescingNotNullable & optionalCh… feat(migrations): Disabling nullishCoalescingNotNullable & optionalChainNotNullable on ng update Apr 8, 2026
@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: migrations Issues related to `ng update`/`ng generate` migrations labels Apr 8, 2026
@ngbot ngbot Bot added this to the Backlog milestone Apr 8, 2026
Comment thread packages/core/schematics/migrations.json Outdated
@aparzi
aparzi force-pushed the migration-strict-safe-navigation-narrow branch from b30f699 to 6462399 Compare April 8, 2026 20:41
@aparzi
aparzi requested a review from JeanMeche April 8, 2026 20:41
Comment thread packages/core/schematics/migrations.json Outdated
@aparzi
aparzi force-pushed the migration-strict-safe-navigation-narrow branch from 6462399 to d387258 Compare April 8, 2026 21:20
@aparzi
aparzi requested a review from JeanMeche April 8, 2026 21:20
@aparzi

aparzi commented Apr 8, 2026

Copy link
Copy Markdown
Contributor Author

@JeanMeche
I updated the PR. Replace boolean value with suppress value

Comment thread packages/core/schematics/migrations/strict-safe-navigation-narrow/index.ts Outdated
@aparzi
aparzi force-pushed the migration-strict-safe-navigation-narrow branch from d387258 to aeccd48 Compare April 9, 2026 08:32
@aparzi
aparzi requested a review from JeanMeche April 9, 2026 08:32
Comment thread packages/core/schematics/migrations/strict-safe-navigation-narrow/index.ts Outdated
@aparzi
aparzi force-pushed the migration-strict-safe-navigation-narrow branch from aeccd48 to 65f213a Compare April 9, 2026 13:12
@aparzi
aparzi requested a review from JeanMeche April 9, 2026 13:12
@aparzi

aparzi commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

@JeanMeche
I changed the entire scaffolding and logic the migration, based at the others

Comment thread packages/core/schematics/migrations/strict-safe-navigation-narrow/migration.ts Outdated
@aparzi
aparzi force-pushed the migration-strict-safe-navigation-narrow branch from 65f213a to 7b8e3d9 Compare April 9, 2026 16:11
@aparzi
aparzi requested a review from JeanMeche April 9, 2026 16:11
@aparzi
aparzi force-pushed the migration-strict-safe-navigation-narrow branch 2 times, most recently from 7b3dcee to 801410b Compare April 9, 2026 20:09
Comment thread packages/core/schematics/migrations/strict-safe-navigation-narrow/migration.ts Outdated
@aparzi
aparzi force-pushed the migration-strict-safe-navigation-narrow branch from 801410b to 349681e Compare April 9, 2026 20:20
@aparzi
aparzi requested a review from JeanMeche April 9, 2026 20:20
Comment thread packages/core/schematics/migrations/strict-safe-navigation-narrow/index.ts Outdated
Comment thread packages/core/schematics/migrations/strict-safe-navigation-narrow/migration.ts Outdated
@aparzi
aparzi force-pushed the migration-strict-safe-navigation-narrow branch from 349681e to 0384c5c Compare April 9, 2026 21:15
@aparzi
aparzi requested a review from JeanMeche April 9, 2026 21:15
@aparzi
aparzi force-pushed the migration-strict-safe-navigation-narrow branch from 0384c5c to 3af620e Compare April 9, 2026 21:20
@aparzi
aparzi requested a review from JeanMeche April 9, 2026 21:20
@aparzi
aparzi requested a review from JeanMeche April 10, 2026 15:48
@JeanMeche

Copy link
Copy Markdown
Member

Can you please address the conflict. Thank you

…ainNotNullable on ng update

Related to angular#67959 disabling two diagnostics errors by `ng update`:

- nullishCoalescingNotNullable
- optionalChainNotNullable
@aparzi
aparzi force-pushed the migration-strict-safe-navigation-narrow branch from 3af620e to b40e074 Compare April 11, 2026 21:20
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Apr 11, 2026
@kirjs
kirjs merged commit 6a43565 into angular:main Apr 13, 2026
23 of 25 checks passed
@kirjs

kirjs commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants