Remove shelljs usage from throughout the repo#64042
Closed
josephperrott wants to merge 5 commits intoangular:mainfrom
Closed
Remove shelljs usage from throughout the repo#64042josephperrott wants to merge 5 commits intoangular:mainfrom
josephperrott wants to merge 5 commits intoangular:mainfrom
Conversation
JeanMeche
approved these changes
Sep 24, 2025
|
|
||
| expect(error).toBe(null); | ||
| if (error) { | ||
| console.log(migrationName); |
Contributor
There was a problem hiding this comment.
These two lines are causing lint errors.
Remove shelljs from zone.js tests
Remove the shelljs usage from package diff script
Update goldens management script to drop shelljs usage
Remove shelljs from package building scripts
Remove shelljs usage from core schematic tests and use builtins instead
285b008 to
b43d5b8
Compare
devversion
approved these changes
Sep 25, 2025
| fs.chmodSync(dirPath, permissions); | ||
|
|
||
| for (const file of fs.readdirSync(dirPath)) { | ||
| recursiveChmod(path.join(dirPath, file), permissions); |
Member
There was a problem hiding this comment.
Wouldn't recursiveChmod also be invoked for files here? Might be worth filtering for readability
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
kirjs
pushed a commit
that referenced
this pull request
Sep 26, 2025
Remove the shelljs usage from package diff script PR Close #64042
kirjs
pushed a commit
that referenced
this pull request
Sep 26, 2025
Update goldens management script to drop shelljs usage PR Close #64042
kirjs
pushed a commit
that referenced
this pull request
Sep 26, 2025
Remove shelljs from package building scripts PR Close #64042
kirjs
pushed a commit
that referenced
this pull request
Sep 26, 2025
Remove shelljs usage from core schematic tests and use builtins instead PR Close #64042
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.