Skip to content

refactor(zone.js): remove legacy browser support#63511

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:zone/remove-legacy
Closed

refactor(zone.js): remove legacy browser support#63511
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:zone/remove-legacy

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Aug 31, 2025 •
edited
Loading

This commit removes the support for legacy browsers.

BREAKING CHANGE: IE/Non-Chromium Edge are not supported anymore.

For testing purposes, to see if this is actually landable.

fixes #37432

@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change area: zones Issues related to zone.js labels Aug 31, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 31, 2025
@JeanMeche JeanMeche force-pushed the zone/remove-legacy branch 3 times, most recently from 21722ca to 378a622 Compare August 31, 2025 18:57
@JeanMeche JeanMeche marked this pull request as ready for review August 31, 2025 19:42
@JeanMeche JeanMeche added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note breaking changes labels Sep 1, 2025
@JeanMeche
Copy link
Copy Markdown
Member Author

JeanMeche commented Sep 1, 2025 •
edited
Loading

Interesting discovery:
The legacy patch allows to use Object.defineProperty multiple times on the same reference : https://stackblitz.com/edit/zone-legacy-defineproperty

Removing it, breaks applications/tests that rely on that behavior.

josephperrott
josephperrott approved these changes Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: dev-infra

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Sep 9, 2025
@JeanMeche JeanMeche marked this pull request as draft September 10, 2025 16:25
thePunderWoman
thePunderWoman approved these changes Sep 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche
refactor(zone.js): remove legacy browser support
7e2d303 
This commit removes the support for legacy browsers.

BREAKING CHANGE: IE/Non-Chromium Edge are not supported anymore.
@JeanMeche JeanMeche marked this pull request as ready for review October 6, 2025 23:07
@JeanMeche JeanMeche added the state: blocked on G3 cleanup This change requires a G3 cleanup label Oct 6, 2025
@JeanMeche JeanMeche removed the state: blocked on G3 cleanup This change requires a G3 cleanup label Oct 15, 2025
@JeanMeche
Copy link
Copy Markdown
Member Author

JeanMeche commented Oct 15, 2025

TGP is green !

@JeanMeche JeanMeche removed the request for review from AndrewKushnir October 15, 2025 00:39
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Oct 15, 2025
@thePunderWoman
Copy link
Copy Markdown
Contributor

thePunderWoman commented Oct 16, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Nov 16, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js breaking changes detected: breaking change PR contains a commit with a breaking change merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

ZoneJS: legacy Object.defineProperty patch breaks configurable descriptor attribute

4 participants

@JeanMeche @thePunderWoman @josephperrott @alan-agius4