fix(zone.js): waitForAsync should pass args to the test function#61755
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(zone.js): waitForAsync should pass args to the test function#61755atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
Contributor
|
Should this also have a matching test for vitest? |
Contributor
Author
|
@NateRadebaugh No, Edit: Added a test for vitest. We do have some private APIs for supporting it without the patches that are in place for jasmine, jest, and mocha while we consider what the plan is for Vitest. |
This ensures that test functions with arguments (e.g. `it.each` in jest) are forwarded to the test function. This does not apply to jasmine, which assumes the only arguments needed would be the `done` function. fixes angular#61717
clydin
approved these changes
Jun 9, 2025
Contributor
|
This PR was merged into the repository by commit 3c216c1. The changes were merged into the following branches: main, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that test functions with arguments (e.g.
it.eachin jest) are forwarded to the test function. This does not apply to jasmine, which assumes the only arguments needed would be thedonefunction.fixes #61717