Skip to content

fix(platform-browser-dynamic): ensure compiler is loaded before @angular/common #60458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devversion wants to merge 1 commit into from
Closed

fix(platform-browser-dynamic): ensure compiler is loaded before @angular/common #60458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/platform-browser-dynamic/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ ng_package(
srcs = [
"package.json",
],
side_effect_entry_points = [
"@angular/platform-browser-dynamic",
"@angular/platform-browser-dynamic/testing",
],
tags = [
"release-with-framework",
],
Expand Down
5 changes: 4 additions & 1 deletion packages/platform-browser-dynamic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,8 @@
"ng-update": {
"packageGroup": "NG_UPDATE_PACKAGE_GROUP"
},
"sideEffects": false
"sideEffects": [
"./fesm2022/platform-browser-dynamic.mjs",
"./fesm2022/testing.mjs"
]
}
5 changes: 5 additions & 0 deletions packages/platform-browser-dynamic/public_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
* @description
* Entry point for all public APIs of this package.
*/

// Note: Historically people relied on `platform-browser-dynamic` magically
// exposing the compiler for JIT. This is now made more explicit via this import.
import '@angular/compiler';

export * from './src/platform-browser-dynamic';

// This file only reexports content of the `src` folder. Keep it that way.
5 changes: 5 additions & 0 deletions packages/platform-browser-dynamic/testing/public_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,9 @@
* @description
* Entry point for all public APIs of this package.
*/

// Note: Historically people relied on `platform-browser-dynamic` magically
// exposing the compiler for JIT. This is now made more explicit via this import.
import '@angular/compiler';

export * from './src/testing';