feat(router): support custom elements for RouterLink#60290
Closed
kyubisation wants to merge 1 commit into
Closed
Conversation
14 tasks
atscott
approved these changes
Mar 14, 2025
Contributor
Author
|
Hello @atscott |
Contributor
|
TGP is green. |
Contributor
|
This PR was merged into the repository by commit ff98ccb. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Relates to #28345
We as Web Component library authors have the problem that routerLink does not properly work with custom element anchor tags (native anchor tag wrapped in Shadow DOM). This is due to the lack of automatic href updates for elements besides
<a>/<area>and the internal logic of adding atabindex="0"attribute for non<a>/<area>elements.What is the new behavior?
If
routerLinkis used on a registered custom element, the static property/getterobservedAttributeson the custom element class is checked for anhrefattribute. Ifhrefis part ofobservedAttributestreats the element as if it was a native<a>element.Does this PR introduce a breaking change?
Other information