Skip to content

fix(core): ensure type is preserved during HMR #59700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crisbeto wants to merge 1 commit into from
Closed

fix(core): ensure type is preserved during HMR #59700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/src/render3/hmr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ function mergeWithExistingDefinition(
// Preserve the old `setInput` function, because it has some state.
// This is fine, because the component instance is preserved as well.
setInput: clone.setInput,

// Externally this is redundant since we redeclare the definition using the original type.
// Internally we may receive a definition with an alternate, but identical, type so we have
// to ensure that the original one is preserved.
type: clone.type,
});

ngDevMode && assertEqual(replacement, currentDef, 'Expected definition to be merged in place');
Expand Down