Skip to content

[FragmentStrictMode] Detect calls to Fragment#setRetainInstance #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonschiller wants to merge 2 commits into from
Closed

[FragmentStrictMode] Detect calls to Fragment#setRetainInstance #140

simonschiller wants to merge 2 commits into from

Conversation

@simonschiller
Copy link
Contributor

@simonschiller simonschiller commented Mar 12, 2021

Proposed Changes

  • Detect calls to Fragment#setRetainInstance

Testing

Test: See FragmentStrictModeTest#detectSetRetainInstance

Issues Fixed

Fixes: 153737954

@simonschiller
Copy link
Contributor Author

simonschiller commented Mar 12, 2021

Similarly to #139, we could only detect calls to Fragment#setRetainInstance, or we could broaden the scope and also detect calls to Fragment#getRetainInstance. What are your opinions on this?

@dlam dlam requested a review from jbw0033 March 15, 2021 19:19
@simonschiller simonschiller mentioned this pull request Mar 15, 2021
Closed
@simonschiller simonschiller deleted the feature/set-retain-instance branch March 23, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tikurahul tikurahul tikurahul approved these changes

@jbw0033 jbw0033 jbw0033 approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simonschiller @tikurahul @jbw0033 @googlebot