Update architecture docs for user news resource flow#2120
Open
ShubhamWorks02 wants to merge 1 commit into
Open
Update architecture docs for user news resource flow#2120ShubhamWorks02 wants to merge 1 commit into
ShubhamWorks02 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the ArchitectureLearningJourney.md documentation to reflect architectural changes. Specifically, it replaces references to the deprecated GetUserNewsResourcesUseCase with the new repository-based approach using UserNewsResourceRepository.observeAllForFollowedTopics and CompositeUserNewsResourceRepository.observeAll. It also updates the domain layer example to use GetFollowableTopicsUseCase instead. There are no review comments to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I have done and why
Updated
docs/ArchitectureLearningJourney.mdso the For You feed flow matches the current implementation.The document referenced
GetUserNewsResourcesUseCase, but the current code usesUserNewsResourceRepository.observeAllForFollowedTopicsfromForYouViewModel.feedState, backed byCompositeUserNewsResourceRepository.This change also updates the domain-layer example to use the existing
GetFollowableTopicsUseCase, which combines topics with user data to produce followable topics.Fixes #2119
Test:
git diff --check