Easier to deserialize JSON format for /remotes.json - #2

Would you not still want to return the response as json with res.json?

Unless I'm mistaken, res.send returns json.
On Dec 13, 2013 1:34 AM, "pmgration" notifications@github.com wrote:

Would you not still want to return the response as json with res.json?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-30491586
.

Ah, I'd read this - http://stackoverflow.com/questions/19041837/difference-between-res-send-and-res-json-in-express-js though it may not still be the case.

Thanks for the tip.
On Dec 13, 2013 8:01 AM, "pmgration" notifications@github.com wrote:

Ah, I'd read this -
http://stackoverflow.com/questions/19041837/difference-between-res-send-and-res-json-in-express-jsthough it may not still be the case.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-30510850
.

Thanks for the pull request! Made two inline comments about some global leaks in the tests, otherwise looks good.

@joe-forbes - If you add the var keyword to the two variables I mentioned above (the tests fail, because those variables leak into the global scope) I'd love to get this pull request merged. Thanks!

Sorry about the delay - I misunderstood your message of Dec. 14 and am just
now coming back from a few days' vacation. I'll make the changes and add
them to the pull request tonight.

Joe

On Tue, Dec 24, 2013 at 11:30 AM, Alex Bain notifications@github.comwrote:

@joe-forbes https://github.com/joe-forbes - If you add the var keyword
to the two variables I mentioned above (the tests fail, because those
variables leak into the global scope) I'd love to get this pull request
merged. Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-31179831
.

Cannot be cleanly merged, closing for now. Feel free to rebase and reopen. Thank you!