Board names changed to be valid python identifiers - #6979

I am very confused as to why the usb id check failed.. I did mv it correctly, checked my history..

Looks like the PR needs to changed tools/ci_check_duplicate_usb_vid_pid.py as well.

PS this script might be one place to add enforcement of the policy for board names to only be valid Python identifiers.

also it looks like at least one "-" is left after this, boards/espressif_kaluga_1-3/board.c

I will try to create a tools/ci_check_board_identifiers.py, that checks all the board names.

I was thinking the ci_check_duplicate script could just have it added, but a separate step/script is fine too.

There is an board alias mechanism which could be used to ease the transition, though I'm not sure if it would produce multiple picture entries in circuitpython.org.

It's also true that the old names are used in the directory tree structure in S3: https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bin. If we rename the directories there, we need to track down any links besides the ones in circuitpython-org. There may be many in the Learn Guides.

If we are going to do a big renaming, we might also consider renaming the older adafruit boards that don't have adafruit_ as a prefix.

I a bit worried whether there's too much churn created by this. One can always take the given board name and substitute _ for - using str.replace() at run-time. I agree it would be good to enforce a standard naming going forward.

I am going to make this a draft while we cogitate on this.

I think a CI check for new boards is best. Is there tooling that needs the python identifier property for all boards?

We discussed closing draft issues that are stuck in the CircuitPython meeting on 2022-11-28 in In the Weeds.

Closing for now. Can be reopened. Tracking in issue #7267, which will remain open.