Fix Version.__hash__ to be consistent with __eq__. - #208
Open
selsky wants to merge 1 commit into
Open
Conversation
Two bugs: 1. __hash__ uses _unparsed (raw string) but __eq__ uses _parsed, so "1" == "1.0" but hash differs. 2. _normalize doesn't recurse into sublists, so _parsed isn't fully canonical: "1-2-0" gets (1,(2,())) instead of (1,(2,)). Fix _normalize to recurse into sublists first, making _parsed canonical, then use hash(_parsed) for __hash__. Fixes aboutcode-org#189 Signed-off-by: Matt Selsky <matthew.selsky@twosigma.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs:
Fix _normalize to recurse into sublists first, making _parsed canonical, then use hash(_parsed) for hash.
Fixes #189