Skip to content

feat: 1.0.0 changes blocking default from true to false #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsavoie merged 2 commits into from
Dec 12, 2025
Merged

feat: 1.0.0 changes blocking default from true to false #537

ehsavoie merged 2 commits into from
Dec 12, 2025

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Dec 12, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 12, 2025

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant change for the upcoming 1.0.0 release by reversing the default behavior of message sending operations. Previously, message sends were blocking by default; they will now be non-blocking by default. This change aims to promote asynchronous processing unless blocking is explicitly required, aligning with common patterns for improved responsiveness and scalability.

Highlights

  • Default Blocking Behavior: The default value for the blocking parameter in MessageSendConfiguration has been changed from true to false. This means message sending operations will now be non-blocking by default, requiring explicit configuration for blocking behavior.
  • Code Logic Update: The DefaultRequestHandler logic was updated to reflect the new default, ensuring that blocking is initialized to false and only set to true if explicitly configured.
  • Test Updates: Existing tests were adjusted to remove explicit blocking(false) configurations, relying on the new default non-blocking behavior. A test method name was also refined for clarity.
  • Documentation and Builder Default: The Javadoc for MessageSendConfiguration and its Builder class were updated to correctly state that blocking now defaults to false.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 12, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements the change of the default behavior for the blocking parameter from true to false. The changes are consistently applied across the implementation, documentation, and tests. The logic is sound, and the updated tests properly verify the new default non-blocking behavior. I have one minor suggestion to improve code conciseness in DefaultRequestHandler.java.

@kabir @gemini-code-assist
Update server-common/src/main/java/io/a2a/server/requesthandlers/Defa…
31cc6b2 
…ultRequestHandler.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ehsavoie ehsavoie merged commit b70b2bf into a2aproject:main Dec 12, 2025
11 checks passed
kabir added a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@kabir @gemini-code-assist
feat: 1.0.0 changes blocking default from true to false (a2aproject#537)
a8ef9cc 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsavoie ehsavoie ehsavoie approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kabir @ehsavoie