chore: add a dedicated javadoc Maven profile #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc is not generated by default. The "Build and Test" GitHub action is run with that profile to validate Javadoc. This fixes a2aproject#525 Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
kabir
reviewed
Dec 10, 2025
Collaborator
kabir
left a comment
There was a problem hiding this comment.
Approved on the understanding that:
- Using the javadoc profile in our test CI runs will pick out any javadoc errors and fail the PR
- The -Prelease job still works the way it did (on the main branch once merged) which guards against 'other stuff' going on which would prevent us from doing a release. This is very unlikely since the main things are the GPG signing and javadoc, and javadoc will be handled earlier now.
kabir
approved these changes
Dec 10, 2025
Collaborator
kabir
left a comment
There was a problem hiding this comment.
Sorry, meant to approve - see earlier comment
kabir
pushed a commit
to kabir/a2a-java
that referenced
this pull request
Dec 23, 2025
Javadoc is not generated by default. The "Build and Test" GitHub action is run with that profile to validate Javadoc. This fixes a2aproject#525 Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javadoc is not generated by default.
The "Build and Test" GitHub action is run with that profile to validate Javadoc.
This fixes #525