fix: Making the event queue overridable #511
Conversation
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Summary of ChangesHello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the extensibility of the event queue mechanism by making key methods public, thereby allowing external components to more easily interact with and customize event processing. Additionally, it improves the debuggability of message events by providing a detailed string representation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Backport of #473 to allow for the timestamp extension |
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on enhancing the extensibility of the EventQueue by adjusting access modifiers of several abstract methods to public. This change allows for greater flexibility when overriding or implementing these methods in different packages, aligning with the goal of making the event queue overridable. Additionally, a toString() method has been added to MessageEvent for improved debugging and logging capabilities.
| String messageAsString = "{" | ||
| + "role=" + message.getRole() | ||
| + ", parts=" + message.getParts() | ||
| + ", messageId=" + message.getMessageId() | ||
| + ", contextId=" + message.getContextId() | ||
| + ", taskId=" + message.getTaskId() | ||
| + ", metadata=" + message.getMetadata() | ||
| + ", kind=" + message.getKind() | ||
| + ", referenceTaskIds=" + message.getReferenceTaskIds() | ||
| + ", extensions=" + message.getExtensions() + '}'; |
There was a problem hiding this comment.
Using StringBuilder for constructing the messageAsString will be more efficient and performant than repeated string concatenation with the + operator, especially if the Message object contains many fields or if this toString() method is called frequently. This is a common Java best practice for string building.
String messageAsString = new StringBuilder("{")
.append("role=").append(message.getRole())
.append(", parts=").append(message.getParts())
.append(", messageId=").append(message.getMessageId())
.append(", contextId=").append(message.getContextId())
.append(", taskId=").append(message.getTaskId())
.append(", metadata=").append(message.getMetadata())
.append(", kind=").append(message.getKind())
.append(", referenceTaskIds=").append(message.getReferenceTaskIds())
.append(", extensions=").append(message.getExtensions())
.append('}')
.toString();
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #<issue_number_goes_here> 🦕