chore: Remove unused imports #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a maintenance effort focused on improving the overall code quality and maintainability of the project. By removing unused import statements, the codebase becomes cleaner, easier to navigate, and less prone to potential issues arising from stale dependencies. This also includes minor formatting adjustments to ensure consistent code style. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes a number of unused imports across the codebase, which is a good cleanup effort. However, it also includes significant formatting changes in several files. While most of these are minor and improve readability, the changes in server-common/src/test/java/io/a2a/server/tasks/TaskManagerTest.java involve re-indenting the entire file, which adds a lot of noise to the PR. I've added a comment to revert this specific change to keep the PR focused.
Comment on lines
30
to
748
| private static final String TASK_JSON = """ | ||
| { | ||
| "id": "task-abc", | ||
| "contextId" : "session-xyz", | ||
| "status": {"state": "submitted"}, | ||
| "kind": "task" | ||
| }"""; | ||
|
|
||
| Task minimalTask; | ||
| TaskStore taskStore; | ||
| TaskManager taskManager; | ||
|
|
||
| @BeforeEach | ||
| public void init() throws Exception { | ||
| minimalTask = Utils.unmarshalFrom(TASK_JSON, Task.TYPE_REFERENCE); | ||
| taskStore = new InMemoryTaskStore(); | ||
| taskManager = new TaskManager(minimalTask.getId(), minimalTask.getContextId(), taskStore, null); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetTaskExisting() { | ||
| Task expectedTask = minimalTask; | ||
| taskStore.save(expectedTask); | ||
| Task retrieved = taskManager.getTask(); | ||
| assertSame(expectedTask, retrieved); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetTaskNonExistent() { | ||
| Task retrieved = taskManager.getTask(); | ||
| assertNull(retrieved); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSaveTaskEventNewTask() throws A2AServerException { | ||
| Task saved = taskManager.saveTaskEvent(minimalTask); | ||
| Task retrieved = taskManager.getTask(); | ||
| assertSame(minimalTask, retrieved); | ||
| assertSame(retrieved, saved); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSaveTaskEventStatusUpdate() throws A2AServerException { | ||
| Task initialTask = minimalTask; | ||
| taskStore.save(initialTask); | ||
|
|
||
| TaskStatus newStatus = new TaskStatus( | ||
| TaskState.WORKING, | ||
| new Message.Builder() | ||
| .role(Message.Role.AGENT) | ||
| .parts(Collections.singletonList(new TextPart("content"))) | ||
| .messageId("messageId") | ||
| .build(), | ||
| null); | ||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent( | ||
| minimalTask.getId(), | ||
| newStatus, | ||
| minimalTask.getContextId(), | ||
| false, | ||
| new HashMap<>()); | ||
|
|
||
| Task saved = taskManager.saveTaskEvent(event); | ||
| Task updated = taskManager.getTask(); | ||
|
|
||
| assertNotSame(initialTask, updated); | ||
| assertSame(updated, saved); | ||
|
|
||
| assertEquals(initialTask.getId(), updated.getId()); | ||
| assertEquals(initialTask.getContextId(), updated.getContextId()); | ||
| // TODO type does not get unmarshalled | ||
| // assertEquals(initialTask.getType(), updated.getType()); | ||
| assertSame(newStatus, updated.getStatus()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSaveTaskEventArtifactUpdate() throws A2AServerException { | ||
| Task initialTask = minimalTask; | ||
| Artifact newArtifact = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("content"))) | ||
| .build(); | ||
| TaskArtifactUpdateEvent event = new TaskArtifactUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .artifact(newArtifact) | ||
| .build(); | ||
| Task saved = taskManager.saveTaskEvent(event); | ||
|
|
||
| Task updatedTask = taskManager.getTask(); | ||
| assertSame(updatedTask, saved); | ||
|
|
||
| assertNotSame(initialTask, updatedTask); | ||
| assertEquals(initialTask.getId(), updatedTask.getId()); | ||
| assertEquals(initialTask.getContextId(), updatedTask.getContextId()); | ||
| assertSame(initialTask.getStatus().state(), updatedTask.getStatus().state()); | ||
| assertEquals(1, updatedTask.getArtifacts().size()); | ||
| assertEquals(newArtifact, updatedTask.getArtifacts().get(0)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testEnsureTaskExisting() { | ||
| // This tests the 'working case' of the internal logic to check a task being | ||
| // updated existas | ||
| // We are already testing that | ||
| } | ||
|
|
||
| @Test | ||
| public void testEnsureTaskNonExistentForStatusUpdate() throws A2AServerException { | ||
| // Tests that an update event instantiates a new task and that | ||
| TaskManager taskManagerWithoutId = new TaskManager(null, null, taskStore, null); | ||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent.Builder() | ||
| .taskId("new-task") | ||
| .contextId("some-context") | ||
| .status(new TaskStatus(TaskState.SUBMITTED)) | ||
| .isFinal(false) | ||
| .build(); | ||
|
|
||
| Task task = taskManagerWithoutId.saveTaskEvent(event); | ||
| assertEquals(event.getTaskId(), taskManagerWithoutId.getTaskId()); | ||
| assertEquals(event.getContextId(), taskManagerWithoutId.getContextId()); | ||
|
|
||
| Task newTask = taskManagerWithoutId.getTask(); | ||
| assertEquals(event.getTaskId(), newTask.getId()); | ||
| assertEquals(event.getContextId(), newTask.getContextId()); | ||
| assertEquals(TaskState.SUBMITTED, newTask.getStatus().state()); | ||
| assertSame(newTask, task); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSaveTaskEventNewTaskNoTaskId() throws A2AServerException { | ||
| TaskManager taskManagerWithoutId = new TaskManager(null, null, taskStore, null); | ||
| Task task = new Task.Builder() | ||
| .id("new-task-id") | ||
| .contextId("some-context") | ||
| .status(new TaskStatus(TaskState.WORKING)) | ||
| .build(); | ||
|
|
||
| Task saved = taskManagerWithoutId.saveTaskEvent(task); | ||
| assertEquals(task.getId(), taskManagerWithoutId.getTaskId()); | ||
| assertEquals(task.getContextId(), taskManagerWithoutId.getContextId()); | ||
|
|
||
| Task retrieved = taskManagerWithoutId.getTask(); | ||
| assertSame(task, retrieved); | ||
| assertSame(retrieved, saved); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetTaskNoTaskId() { | ||
| TaskManager taskManagerWithoutId = new TaskManager(null, null, taskStore, null); | ||
| Task retrieved = taskManagerWithoutId.getTask(); | ||
| assertNull(retrieved); | ||
| } | ||
|
|
||
| // Additional tests for missing coverage scenarios | ||
|
|
||
| @Test | ||
| public void testTaskArtifactUpdateEventAppendTrueWithExistingArtifact() throws A2AServerException { | ||
| // Setup: Create a task with an existing artifact | ||
| Task initialTask = minimalTask; | ||
| Artifact existingArtifact = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("existing content"))) | ||
| .build(); | ||
| Task taskWithArtifact = new Task.Builder(initialTask) | ||
| .artifacts(Collections.singletonList(existingArtifact)) | ||
| .build(); | ||
| taskStore.save(taskWithArtifact); | ||
|
|
||
| // Test: Append new parts to existing artifact | ||
| Artifact newArtifact = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("new content"))) | ||
| .build(); | ||
| TaskArtifactUpdateEvent event = new TaskArtifactUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .artifact(newArtifact) | ||
| .append(true) | ||
| .build(); | ||
|
|
||
| Task updatedTask = taskManager.saveTaskEvent(event); | ||
|
|
||
| assertEquals(1, updatedTask.getArtifacts().size()); | ||
| Artifact updatedArtifact = updatedTask.getArtifacts().get(0); | ||
| assertEquals("artifact-id", updatedArtifact.artifactId()); | ||
| assertEquals(2, updatedArtifact.parts().size()); | ||
| assertEquals("existing content", ((TextPart) updatedArtifact.parts().get(0)).getText()); | ||
| assertEquals("new content", ((TextPart) updatedArtifact.parts().get(1)).getText()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTaskArtifactUpdateEventAppendTrueWithoutExistingArtifact() throws A2AServerException { | ||
| // Setup: Create a task without artifacts | ||
| Task initialTask = minimalTask; | ||
| taskStore.save(initialTask); | ||
|
|
||
| // Test: Try to append to non-existent artifact (should be ignored) | ||
| Artifact newArtifact = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("new content"))) | ||
| .build(); | ||
| TaskArtifactUpdateEvent event = new TaskArtifactUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .artifact(newArtifact) | ||
| .append(true) | ||
| .build(); | ||
|
|
||
| Task saved = taskManager.saveTaskEvent(event); | ||
| Task updatedTask = taskManager.getTask(); | ||
|
|
||
| // Should have no artifacts since append was ignored | ||
| assertEquals(0, updatedTask.getArtifacts().size()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTaskArtifactUpdateEventAppendFalseWithExistingArtifact() throws A2AServerException { | ||
| // Setup: Create a task with an existing artifact | ||
| Task initialTask = minimalTask; | ||
| Artifact existingArtifact = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("existing content"))) | ||
| .build(); | ||
| Task taskWithArtifact = new Task.Builder(initialTask) | ||
| .artifacts(Collections.singletonList(existingArtifact)) | ||
| .build(); | ||
| taskStore.save(taskWithArtifact); | ||
|
|
||
| // Test: Replace existing artifact (append=false) | ||
| Artifact newArtifact = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("replacement content"))) | ||
| .build(); | ||
| TaskArtifactUpdateEvent event = new TaskArtifactUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .artifact(newArtifact) | ||
| .append(false) | ||
| .build(); | ||
|
|
||
| Task saved = taskManager.saveTaskEvent(event); | ||
| Task updatedTask = taskManager.getTask(); | ||
|
|
||
| assertEquals(1, updatedTask.getArtifacts().size()); | ||
| Artifact updatedArtifact = updatedTask.getArtifacts().get(0); | ||
| assertEquals("artifact-id", updatedArtifact.artifactId()); | ||
| assertEquals(1, updatedArtifact.parts().size()); | ||
| assertEquals("replacement content", ((TextPart) updatedArtifact.parts().get(0)).getText()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTaskArtifactUpdateEventAppendNullWithExistingArtifact() throws A2AServerException { | ||
| // Setup: Create a task with an existing artifact | ||
| Task initialTask = minimalTask; | ||
| Artifact existingArtifact = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("existing content"))) | ||
| .build(); | ||
| Task taskWithArtifact = new Task.Builder(initialTask) | ||
| .artifacts(Collections.singletonList(existingArtifact)) | ||
| .build(); | ||
| taskStore.save(taskWithArtifact); | ||
|
|
||
| // Test: Replace existing artifact (append=null, defaults to false) | ||
| Artifact newArtifact = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("replacement content"))) | ||
| .build(); | ||
| TaskArtifactUpdateEvent event = new TaskArtifactUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .artifact(newArtifact) | ||
| .build(); // append is null | ||
|
|
||
| Task saved = taskManager.saveTaskEvent(event); | ||
| Task updatedTask = taskManager.getTask(); | ||
|
|
||
| assertEquals(1, updatedTask.getArtifacts().size()); | ||
| Artifact updatedArtifact = updatedTask.getArtifacts().get(0); | ||
| assertEquals("artifact-id", updatedArtifact.artifactId()); | ||
| assertEquals(1, updatedArtifact.parts().size()); | ||
| assertEquals("replacement content", ((TextPart) updatedArtifact.parts().get(0)).getText()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testAddingTaskWithDifferentIdFails() { | ||
| // Test that adding a task with a different id from the taskmanager's taskId | ||
| // fails | ||
| TaskManager taskManagerWithId = new TaskManager("task-abc", "session-xyz", taskStore, null); | ||
|
|
||
| Task differentTask = new Task.Builder() | ||
| .id("different-task-id") | ||
| .contextId("session-xyz") | ||
| .status(new TaskStatus(TaskState.SUBMITTED)) | ||
| .build(); | ||
|
|
||
| assertThrows(A2AServerException.class, () -> { | ||
| taskManagerWithId.saveTaskEvent(differentTask); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void testAddingTaskWithDifferentIdViaStatusUpdateFails() { | ||
| // Test that adding a status update with different taskId fails | ||
| TaskManager taskManagerWithId = new TaskManager("task-abc", "session-xyz", taskStore, null); | ||
|
|
||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent.Builder() | ||
| .taskId("different-task-id") | ||
| .contextId("session-xyz") | ||
| .status(new TaskStatus(TaskState.WORKING)) | ||
| .isFinal(false) | ||
| .build(); | ||
|
|
||
| assertThrows(A2AServerException.class, () -> { | ||
| taskManagerWithId.saveTaskEvent(event); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void testAddingTaskWithDifferentIdViaArtifactUpdateFails() { | ||
| // Test that adding an artifact update with different taskId fails | ||
| TaskManager taskManagerWithId = new TaskManager("task-abc", "session-xyz", taskStore, null); | ||
|
|
||
| Artifact artifact = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("content"))) | ||
| .build(); | ||
| TaskArtifactUpdateEvent event = new TaskArtifactUpdateEvent.Builder() | ||
| .taskId("different-task-id") | ||
| .contextId("session-xyz") | ||
| .artifact(artifact) | ||
| .build(); | ||
|
|
||
| assertThrows(A2AServerException.class, () -> { | ||
| taskManagerWithId.saveTaskEvent(event); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTaskWithNoMessageUsesInitialMessage() throws A2AServerException { | ||
| // Test that adding a task with no message, and there is a | ||
| // TaskManager.initialMessage, | ||
| // the initialMessage gets used | ||
| Message initialMessage = new Message.Builder() | ||
| .role(Message.Role.USER) | ||
| .parts(Collections.singletonList(new TextPart("initial message"))) | ||
| .messageId("initial-msg-id") | ||
| .build(); | ||
|
|
||
| TaskManager taskManagerWithInitialMessage = new TaskManager(null, null, taskStore, initialMessage); | ||
|
|
||
| // Use a status update event instead of a Task to trigger createTask | ||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent.Builder() | ||
| .taskId("new-task-id") | ||
| .contextId("some-context") | ||
| .status(new TaskStatus(TaskState.SUBMITTED)) | ||
| .isFinal(false) | ||
| .build(); | ||
|
|
||
| Task saved = taskManagerWithInitialMessage.saveTaskEvent(event); | ||
| Task retrieved = taskManagerWithInitialMessage.getTask(); | ||
|
|
||
| // Check that the task has the initial message in its history | ||
| assertNotNull(retrieved.getHistory()); | ||
| assertEquals(1, retrieved.getHistory().size()); | ||
| Message historyMessage = retrieved.getHistory().get(0); | ||
| assertEquals(initialMessage.getMessageId(), historyMessage.getMessageId()); | ||
| assertEquals(initialMessage.getRole(), historyMessage.getRole()); | ||
| assertEquals("initial message", ((TextPart) historyMessage.getParts().get(0)).getText()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTaskWithMessageDoesNotUseInitialMessage() throws A2AServerException { | ||
| // Test that adding a task with a message does not use the initial message | ||
| Message initialMessage = new Message.Builder() | ||
| .role(Message.Role.USER) | ||
| .parts(Collections.singletonList(new TextPart("initial message"))) | ||
| .messageId("initial-msg-id") | ||
| .build(); | ||
|
|
||
| TaskManager taskManagerWithInitialMessage = new TaskManager(null, null, taskStore, initialMessage); | ||
|
|
||
| Message taskMessage = new Message.Builder() | ||
| .role(Message.Role.AGENT) | ||
| .parts(Collections.singletonList(new TextPart("task message"))) | ||
| .messageId("task-msg-id") | ||
| .build(); | ||
|
|
||
| // Use TaskStatusUpdateEvent to trigger the creation of a task, which will check | ||
| // if the initialMessage is used. | ||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent.Builder() | ||
| .taskId("new-task-id") | ||
| .contextId("some-context") | ||
| .status(new TaskStatus(TaskState.SUBMITTED, taskMessage, null)) | ||
| .isFinal(false) | ||
| .build(); | ||
|
|
||
| Task saved = taskManagerWithInitialMessage.saveTaskEvent(event); | ||
| Task retrieved = taskManagerWithInitialMessage.getTask(); | ||
|
|
||
| // There should now be a history containing the initialMessage | ||
| // But the current message (taskMessage) should be in the state, not in the | ||
| // history | ||
| assertNotNull(retrieved.getHistory()); | ||
| assertEquals(1, retrieved.getHistory().size()); | ||
| assertEquals("initial message", ((TextPart) retrieved.getHistory().get(0).getParts().get(0)).getText()); | ||
|
|
||
| // The message in the current state should be taskMessage | ||
| assertNotNull(retrieved.getStatus().message()); | ||
| assertEquals("task message", ((TextPart) retrieved.getStatus().message().getParts().get(0)).getText()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testMultipleArtifactsWithSameArtifactId() throws A2AServerException { | ||
| // Test handling of multiple artifacts with the same artifactId | ||
| Task initialTask = minimalTask; | ||
| taskStore.save(initialTask); | ||
|
|
||
| // Add first artifact | ||
| Artifact artifact1 = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("content 1"))) | ||
| .build(); | ||
| TaskArtifactUpdateEvent event1 = new TaskArtifactUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .artifact(artifact1) | ||
| .build(); | ||
| taskManager.saveTaskEvent(event1); | ||
|
|
||
| // Add second artifact with same artifactId (should replace the first) | ||
| Artifact artifact2 = new Artifact.Builder() | ||
| .artifactId("artifact-id") | ||
| .name("artifact-2") | ||
| .parts(Collections.singletonList(new TextPart("content 2"))) | ||
| .build(); | ||
| TaskArtifactUpdateEvent event2 = new TaskArtifactUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .artifact(artifact2) | ||
| .build(); | ||
| taskManager.saveTaskEvent(event2); | ||
|
|
||
| Task updatedTask = taskManager.getTask(); | ||
| assertEquals(1, updatedTask.getArtifacts().size()); | ||
| Artifact finalArtifact = updatedTask.getArtifacts().get(0); | ||
| assertEquals("artifact-id", finalArtifact.artifactId()); | ||
| assertEquals("artifact-2", finalArtifact.name()); | ||
| assertEquals("content 2", ((TextPart) finalArtifact.parts().get(0)).getText()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testMultipleArtifactsWithDifferentArtifactIds() throws A2AServerException { | ||
| // Test handling of multiple artifacts with different artifactIds | ||
| Task initialTask = minimalTask; | ||
| taskStore.save(initialTask); | ||
|
|
||
| // Add first artifact | ||
| Artifact artifact1 = new Artifact.Builder() | ||
| .artifactId("artifact-id-1") | ||
| .name("artifact-1") | ||
| .parts(Collections.singletonList(new TextPart("content 1"))) | ||
| .build(); | ||
| TaskArtifactUpdateEvent event1 = new TaskArtifactUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .artifact(artifact1) | ||
| .build(); | ||
| taskManager.saveTaskEvent(event1); | ||
|
|
||
| // Add second artifact with different artifactId (should be added) | ||
| Artifact artifact2 = new Artifact.Builder() | ||
| .artifactId("artifact-id-2") | ||
| .name("artifact-2") | ||
| .parts(Collections.singletonList(new TextPart("content 2"))) | ||
| .build(); | ||
| TaskArtifactUpdateEvent event2 = new TaskArtifactUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .artifact(artifact2) | ||
| .build(); | ||
| taskManager.saveTaskEvent(event2); | ||
|
|
||
| Task updatedTask = taskManager.getTask(); | ||
| assertEquals(2, updatedTask.getArtifacts().size()); | ||
|
|
||
| // Verify both artifacts are present | ||
| List<Artifact> artifacts = updatedTask.getArtifacts(); | ||
| assertTrue(artifacts.stream() | ||
| .anyMatch(a -> "artifact-id-1".equals(a.artifactId()) | ||
| && "content 1".equals(((TextPart) a.parts().get(0)).getText())), | ||
| "Artifact 1 should be present"); | ||
| assertTrue(artifacts.stream() | ||
| .anyMatch(a -> "artifact-id-2".equals(a.artifactId()) | ||
| && "content 2".equals(((TextPart) a.parts().get(0)).getText())), | ||
| "Artifact 2 should be present"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testInvalidTaskIdValidation() { | ||
| // Test that creating TaskManager with null taskId is allowed (Python allows | ||
| // None) | ||
| TaskManager taskManagerWithNullId = new TaskManager(null, "context", taskStore, null); | ||
| assertNull(taskManagerWithNullId.getTaskId()); | ||
|
|
||
| // Test that empty string task ID is handled (Java doesn't have explicit | ||
| // validation like Python) | ||
| TaskManager taskManagerWithEmptyId = new TaskManager("", "context", taskStore, null); | ||
| assertEquals("", taskManagerWithEmptyId.getTaskId()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSaveTaskEventMetadataUpdate() throws A2AServerException { | ||
| // Test that metadata from TaskStatusUpdateEvent gets saved to the task | ||
| Task initialTask = minimalTask; | ||
| taskStore.save(initialTask); | ||
|
|
||
| Map<String, Object> newMetadata = new HashMap<>(); | ||
| newMetadata.put("meta_key_test", "meta_value_test"); | ||
|
|
||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .status(new TaskStatus(TaskState.WORKING)) | ||
| .isFinal(false) | ||
| .metadata(newMetadata) | ||
| .build(); | ||
|
|
||
| taskManager.saveTaskEvent(event); | ||
|
|
||
| Task updatedTask = taskManager.getTask(); | ||
| assertEquals(newMetadata, updatedTask.getMetadata()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSaveTaskEventMetadataUpdateNull() throws A2AServerException { | ||
| // Test that null metadata in TaskStatusUpdateEvent doesn't affect task | ||
| Task initialTask = minimalTask; | ||
| taskStore.save(initialTask); | ||
|
|
||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .status(new TaskStatus(TaskState.WORKING)) | ||
| .isFinal(false) | ||
| .metadata(null) | ||
| .build(); | ||
|
|
||
| taskManager.saveTaskEvent(event); | ||
|
|
||
| Task updatedTask = taskManager.getTask(); | ||
| // Should preserve original task's metadata (which is likely null for minimal | ||
| // task) | ||
| assertNull(updatedTask.getMetadata()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSaveTaskEventMetadataMergeExisting() throws A2AServerException { | ||
| // Test that metadata update merges with existing metadata | ||
| Map<String, Object> originalMetadata = new HashMap<>(); | ||
| originalMetadata.put("original_key", "original_value"); | ||
|
|
||
| Task taskWithMetadata = new Task.Builder(minimalTask) | ||
| .metadata(originalMetadata) | ||
| .build(); | ||
| taskStore.save(taskWithMetadata); | ||
|
|
||
| Map<String, Object> newMetadata = new HashMap<>(); | ||
| newMetadata.put("new_key", "new_value"); | ||
|
|
||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent.Builder() | ||
| .taskId(minimalTask.getId()) | ||
| .contextId(minimalTask.getContextId()) | ||
| .status(new TaskStatus(TaskState.WORKING)) | ||
| .isFinal(false) | ||
| .metadata(newMetadata) | ||
| .build(); | ||
|
|
||
| taskManager.saveTaskEvent(event); | ||
|
|
||
| Task updatedTask = taskManager.getTask(); | ||
|
|
||
| Map<String, Object> mergedMetadata = new HashMap<>(originalMetadata); | ||
| mergedMetadata.putAll(newMetadata); | ||
| assertEquals(mergedMetadata, updatedTask.getMetadata()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCreateTaskWithInitialMessage() throws A2AServerException { | ||
| // Test equivalent of _init_task_obj functionality | ||
| Message initialMessage = new Message.Builder() | ||
| .role(Message.Role.USER) | ||
| .parts(Collections.singletonList(new TextPart("initial message"))) | ||
| .messageId("initial-msg-id") | ||
| .build(); | ||
|
|
||
| TaskManager taskManagerWithMessage = new TaskManager(null, null, taskStore, initialMessage); | ||
|
|
||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent.Builder() | ||
| .taskId("new-task-id") | ||
| .contextId("some-context") | ||
| .status(new TaskStatus(TaskState.SUBMITTED)) | ||
| .isFinal(false) | ||
| .build(); | ||
|
|
||
| Task savedTask = taskManagerWithMessage.saveTaskEvent(event); | ||
|
|
||
| // Verify task was created properly | ||
| assertNotNull(savedTask); | ||
| assertEquals("new-task-id", savedTask.getId()); | ||
| assertEquals("some-context", savedTask.getContextId()); | ||
| assertEquals(TaskState.SUBMITTED, savedTask.getStatus().state()); | ||
|
|
||
| // Verify initial message is in history | ||
| assertNotNull(savedTask.getHistory()); | ||
| assertEquals(1, savedTask.getHistory().size()); | ||
| Message historyMessage = savedTask.getHistory().get(0); | ||
| assertEquals("initial-msg-id", historyMessage.getMessageId()); | ||
| assertEquals("initial message", ((TextPart) historyMessage.getParts().get(0)).getText()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCreateTaskWithoutInitialMessage() throws A2AServerException { | ||
| // Test task creation without initial message | ||
| TaskManager taskManagerWithoutMessage = new TaskManager(null, null, taskStore, null); | ||
|
|
||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent.Builder() | ||
| .taskId("new-task-id") | ||
| .contextId("some-context") | ||
| .status(new TaskStatus(TaskState.SUBMITTED)) | ||
| .isFinal(false) | ||
| .build(); | ||
|
|
||
| Task savedTask = taskManagerWithoutMessage.saveTaskEvent(event); | ||
|
|
||
| // Verify task was created properly | ||
| assertNotNull(savedTask); | ||
| assertEquals("new-task-id", savedTask.getId()); | ||
| assertEquals("some-context", savedTask.getContextId()); | ||
| assertEquals(TaskState.SUBMITTED, savedTask.getStatus().state()); | ||
|
|
||
| // Verify no history since there was no initial message | ||
| assertTrue(savedTask.getHistory().isEmpty()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testSaveTaskInternal() throws A2AServerException { | ||
| // Test equivalent of _save_task functionality through saveTaskEvent | ||
| TaskManager taskManagerWithoutId = new TaskManager(null, null, taskStore, null); | ||
|
|
||
| Task newTask = new Task.Builder() | ||
| .id("test-task-id") | ||
| .contextId("test-context") | ||
| .status(new TaskStatus(TaskState.WORKING)) | ||
| .build(); | ||
|
|
||
| Task savedTask = taskManagerWithoutId.saveTaskEvent(newTask); | ||
|
|
||
| // Verify internal state was updated | ||
| assertEquals("test-task-id", taskManagerWithoutId.getTaskId()); | ||
| assertEquals("test-context", taskManagerWithoutId.getContextId()); | ||
| assertSame(savedTask, taskManagerWithoutId.getTask()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testUpdateWithMessage() throws A2AServerException { | ||
| Message initialMessage = new Message.Builder() | ||
| .role(Message.Role.USER) | ||
| .parts(Collections.singletonList(new TextPart("initial message"))) | ||
| .messageId("initial-msg-id") | ||
| .build(); | ||
|
|
||
| TaskManager taskManagerWithInitialMessage = new TaskManager(null, null, taskStore, initialMessage); | ||
|
|
||
| Message taskMessage = new Message.Builder() | ||
| .role(Message.Role.AGENT) | ||
| .parts(Collections.singletonList(new TextPart("task message"))) | ||
| .messageId("task-msg-id") | ||
| .build(); | ||
|
|
||
| TaskStatusUpdateEvent event = new TaskStatusUpdateEvent.Builder() | ||
| .taskId("new-task-id") | ||
| .contextId("some-context") | ||
| .status(new TaskStatus(TaskState.SUBMITTED, taskMessage, null)) | ||
| .isFinal(false) | ||
| .build(); | ||
|
|
||
| Task saved = taskManagerWithInitialMessage.saveTaskEvent(event); | ||
|
|
||
| Message updateMessage = new Message.Builder() | ||
| .role(Message.Role.USER) | ||
| .parts(Collections.singletonList(new TextPart("update message"))) | ||
| .messageId("update-msg-id") | ||
| .build(); | ||
|
|
||
| Task updated = taskManagerWithInitialMessage.updateWithMessage(updateMessage, saved); | ||
|
|
||
| // There should now be a history containing the initialMessage, task message and | ||
| // update message | ||
| assertNotNull(updated.getHistory()); | ||
| assertEquals(3, updated.getHistory().size()); | ||
| assertEquals("initial message", ((TextPart) updated.getHistory().get(0).getParts().get(0)).getText()); | ||
|
|
||
| // The message in the current state should be null | ||
| assertNull(updated.getStatus().message()); | ||
| assertEquals("task message", ((TextPart) updated.getHistory().get(1).getParts().get(0)).getText()); | ||
| assertEquals("update message", ((TextPart) updated.getHistory().get(2).getParts().get(0)).getText()); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This large-scale formatting change re-indents the entire file, which makes it difficult to review and verify that no functional changes have been accidentally introduced. To keep pull requests focused on a single concern, it would be better to revert the formatting changes in this file. If re-formatting is desired, it should be done in a separate pull request.
fjuma
approved these changes
Nov 20, 2025
ehsavoie
approved these changes
Nov 20, 2025
kabir
added a commit
to kabir/a2a-java
that referenced
this pull request
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.