feat: Introduce BOMs #462
feat: Introduce BOMs #462
Conversation
There are boms for: * the core sdk classes * the reference classes (includes core sdk) * the extras classes (includes core sdk)
|
@ChenKangQiang Does this look like what you had in mind? |
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the A2A Java SDK's usability for external developers by introducing a structured Bill of Materials (BOM) system. This system simplifies dependency management, allowing users to easily integrate SDK modules into their projects (whether vanilla Java, Spring Boot, or Quarkus-based) by importing a single BOM, which automatically handles compatible versions of all transitive dependencies. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces Bill of Materials (BOMs) for managing dependencies, which is a great improvement for the project's consumers. The implementation is solid, including a comprehensive testing strategy using the maven-invoker-plugin to validate the BOMs. My review focuses on a few inconsistencies in the BOM definitions and their corresponding tests to ensure correctness and maintainability.
boms/sdk/src/it/sdk-usage-test/src/main/java/io/a2a/test/SdkBomVerifier.java
Show resolved
Hide resolved
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces Bill of Materials (BOMs) for the SDK, extras, and reference modules, which is a fantastic addition for consumers of this library. The implementation is very well-structured, especially the integration testing strategy using maven-invoker-plugin and a dynamic class verifier. My feedback focuses on making the test utilities more robust and maintainable, and ensuring dependency scopes are correctly defined in the new BOMs.
boms/test-utils/src/main/java/io/a2a/bom/test/DynamicBomVerifier.java
Outdated
Show resolved
Hide resolved
boms/test-utils/src/main/java/io/a2a/bom/test/DynamicBomVerifier.java
Outdated
Show resolved
Hide resolved
boms/README.md
Outdated
| <dependency> | ||
| <groupId>io.github.a2asdk</groupId> | ||
| <artifactId>a2a-java-sdk-extras-bom</artifactId> | ||
| <version>0.4.0.Alpha1-SNAPSHOT</version> |
There was a problem hiding this comment.
We should use the property here too :)
boms/README.md
Outdated
| <dependency> | ||
| <groupId>io.github.a2asdk</groupId> | ||
| <artifactId>a2a-java-sdk-reference-bom</artifactId> | ||
| <version>0.4.0.Alpha1-SNAPSHOT</version> |
|
@fjuma updated |
There are boms for: * the core sdk classes * the reference classes (includes core sdk) * the extras classes (includes core sdk) Fixes a2aproject#461
There are boms for:
Fixes #461