Skip to content

fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kabir merged 1 commit into from
Nov 5, 2025
Merged

fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks #444

kabir merged 1 commit into from
Nov 5, 2025

Conversation

@ehsavoie
Copy link
Collaborator

@ehsavoie ehsavoie commented Nov 4, 2025 •
edited
Loading

Simple fix for JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks ensuring that the DoneCallback is not null when mocking.

@ehsavoie ehsavoie added the hold label Nov 4, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 4, 2025

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the clarity of error messages within the DefaultRequestHandler by appending the underlying exception's message to the log output when a java.util.concurrent.ExecutionException is caught. This change aims to provide more immediate and useful debugging information for task execution failures.

Highlights

  • Enhanced Error Reporting: Modified the DefaultRequestHandler to include the specific exception message when a java.util.concurrent.ExecutionException occurs during task execution, providing more detailed error information.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request aims to provide more detailed error messages by including the exception's message in the log and the InternalError message. This is a good improvement for debugging and understanding the root cause of issues. The change is minimal and directly addresses the objective stated in the pull request title.

@ehsavoie
fix: fNPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccess…
e978efc 
…Mocks

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@ehsavoie ehsavoie removed the hold label Nov 5, 2025
@ehsavoie ehsavoie requested a review from kabir November 5, 2025 09:10
@ehsavoie ehsavoie changed the title Trying to get more details fix: fNPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks Nov 5, 2025
@ehsavoie ehsavoie changed the title fix: fNPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks Nov 5, 2025
@kabir kabir merged commit 8197ec8 into a2aproject:main Nov 5, 2025
10 of 13 checks passed
kabir pushed a commit to kabir/a2a-java that referenced this pull request Nov 5, 2025
@ehsavoie @kabir
fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessM…
c17a4d4 
…ocks (a2aproject#444)

Simple fix for JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks
ensuring that the DoneCallback is not null when mocking.

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@kabir kabir mentioned this pull request Nov 5, 2025
Merged
kabir added a commit that referenced this pull request Nov 5, 2025
@kabir @ehsavoie
fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessM… (
3599357 
#446)

…ocks (#444)

Simple fix for JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks
ensuring that the DoneCallback is not null when mocking.

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Co-authored-by: Emmanuel Hugonnet <ehsavoie@users.noreply.github.com>
@ehsavoie ehsavoie deleted the intermittent branch December 11, 2025 08:23
kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@ehsavoie @kabir
fix: NPE with test JSONRPCHandlerTest.testOnMessageNewMessageSuccessM…
d86b839 
…ocks (a2aproject#444)

Simple fix for JSONRPCHandlerTest.testOnMessageNewMessageSuccessMocks
ensuring that the DoneCallback is not null when mocking.

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kabir kabir Awaiting requested review from kabir

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ehsavoie @kabir