Skip to content

fix: Improve Kubernetes Example reliability on CI #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kabir merged 2 commits into from
Nov 18, 2025
Merged

fix: Improve Kubernetes Example reliability on CI #435

kabir merged 2 commits into from
Nov 18, 2025

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Nov 3, 2025

  • exit early once we have the two required pods
  • increased count until we expect 2 pods

Fixes #396 🦕

@kabir
fix: Improve Kubernetes Example reliability on CI
2d02921 
- exit early once we have the two required pods
- increased count until we expect 2 pods
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 3, 2025

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the reliability and efficiency of the Kubernetes example test within CI environments. By introducing configurable parameters and a dedicated CI mode, the test can now dynamically adjust its behavior to wait longer for necessary resources (pods) to become available, while also terminating early once conditions are met. This change aims to reduce test flakiness and speed up CI feedback cycles without compromising test coverage.

Highlights

  • Configurable Test Parameters: The Kubernetes example client now allows PROCESS_MESSAGE_COUNT and MESSAGE_INTERVAL_MS to be configured via system properties, enhancing test flexibility.
  • CI Mode Introduction: A new CI_MODE system property has been added, enabling specific behaviors for continuous integration environments.
  • Early Exit for Pod Observation: In CI_MODE, the test will now stop sending messages early once two pods have been successfully observed, optimizing CI run times.
  • Increased Message Count in CI: The maximum number of messages sent in CI_MODE (MAX_MESSAGES_UNTIL_TWO_PODS) has been increased to 20, providing more time for pods to initialize and become observable.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/cloud-deployment-example.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the reliability of the Kubernetes example test on CI by introducing a configurable CI mode. In this mode, the test sends messages until it observes two distinct pods, with a maximum message limit to prevent indefinite runs. This is a solid approach to handle potential flakiness in a load-balanced environment. The implementation is correct. I've added a couple of suggestions to replace a magic number with a constant for better code maintainability.

@kabir kabir merged commit 937290a into a2aproject:main Nov 18, 2025
10 checks passed
@jmesnil jmesnil added this to the 1.0.0 milestone Dec 11, 2025
kabir added a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@kabir
fix: Improve Kubernetes Example reliability on CI (a2aproject#435)
e0a21d6 
- exit early once we have the two required pods
- increased count until we expect 2 pods

Fixes a2aproject#396 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjuma fjuma fjuma approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Occasional failures in Kubernetes example

3 participants

@kabir @fjuma @jmesnil