chore: Next is 0.3.2 #420
chore: Next is 0.3.2 #420
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine version bump for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request consistently updates the project version to 0.3.2.Beta1-SNAPSHOT across all Maven modules and related files. The changes appear correct for preparing the next development version. I have one suggestion regarding the jbang example script to improve its maintainability by removing the hardcoded dependency versions.
| //DEPS io.github.a2asdk:a2a-java-sdk-client:0.3.2.Beta1-SNAPSHOT | ||
| //DEPS io.github.a2asdk:a2a-java-sdk-client-transport-jsonrpc:0.3.2.Beta1-SNAPSHOT |
There was a problem hiding this comment.
To improve maintainability and avoid having to manually update dependency versions in this file for every release, you can leverage jbang's ability to resolve dependencies from a pom.xml file. This ensures that the example always uses the version defined in the Maven build.
By using //DEPS pom.xml, jbang will automatically find the pom.xml in the parent directory (examples/helloworld/client/pom.xml) and use the dependencies defined there. This includes transitive dependencies, so a2a-java-sdk-client-transport-jsonrpc will be correctly resolved.
| //DEPS io.github.a2asdk:a2a-java-sdk-client:0.3.2.Beta1-SNAPSHOT | |
| //DEPS io.github.a2asdk:a2a-java-sdk-client-transport-jsonrpc:0.3.2.Beta1-SNAPSHOT | |
| //DEPS pom.xml |
No description provided.