fix: Changes needed to have ConfigProperty injection working in Jakarta #417
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request addresses an issue with ConfigProperty injection in Jakarta environments by adding @Inject annotations and correcting a type for keepAliveSeconds. This change ensures proper dependency injection for configuration properties, which is crucial for the application's correct functioning outside of specific runtimes like Quarkus that might handle this implicitly. The changes are well-focused and directly resolve the stated problem.
server-common/src/main/java/io/a2a/server/util/async/AsyncExecutorProducer.java
Show resolved
Hide resolved
server-common/src/main/java/io/a2a/server/util/async/AsyncExecutorProducer.java
Show resolved
Hide resolved
server-common/src/main/java/io/a2a/server/util/async/AsyncExecutorProducer.java
Show resolved
Hide resolved
| @Inject // Needed to work in standard Jakarta runtimes (Quarkus skips this) | ||
| @ConfigProperty(name = "a2a.executor.keep-alive-seconds", defaultValue = "60") | ||
| long keepAliveSeconds; | ||
| int keepAliveSeconds; |
There was a problem hiding this comment.
The addition of @Inject for keepAliveSeconds is correct. Additionally, changing the type from long to int is appropriate given the default value of "60" and typical usage of keepAliveSeconds in ThreadPoolExecutor which expects an int for time units less than DAYS.
| @Inject // Needed to work in standard Jakarta runtimes (Quarkus skips this) | |
| @ConfigProperty(name = "a2a.executor.keep-alive-seconds", defaultValue = "60") | |
| long keepAliveSeconds; | |
| int keepAliveSeconds; | |
| @Inject // Needed to work in standard Jakarta runtimes (Quarkus skips this) | |
| @ConfigProperty(name = "a2a.executor.keep-alive-seconds", defaultValue = "60") | |
| int keepAliveSeconds; |
No description provided.