fix: Clean up the k8s example pom, and the extras application properties #416
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on advancing the project's version to "0.3.1.Beta1-SNAPSHOT" across its entire module structure. Beyond this widespread version bump, it includes targeted cleanups such as removing unnecessary dependencies in the cloud deployment example and streamlining Quarkus configuration by eliminating explicit alternative selections in test application properties. These changes aim to prepare the codebase for the next development iteration and improve overall project consistency. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| <artifactId>quarkus-hibernate-orm</artifactId> | ||
| </dependency> | ||
|
|
||
| <!-- Quarkus REST/JAX-RS --> | ||
| <dependency> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-resteasy-jackson</artifactId> | ||
| </dependency> | ||
|
|
||
| <!-- Quarkus Health checks --> | ||
| <dependency> |
There was a problem hiding this comment.
These dependencies are no longer needed and can be removed to reduce the size of the application and improve build times. Removing unused dependencies helps in maintaining a cleaner and more efficient project structure.
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy-jackson</artifactId>
</dependency>
<!-- Quarkus Health checks -->
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-smallrye-health</artifactId>
</dependency>There was a problem hiding this comment.
These are needed, and Jackson is removed
| # Configure PostgreSQL database (connection details will be provided by Testcontainers) | ||
| quarkus.datasource."a2a-java".db-kind=postgresql |
There was a problem hiding this comment.
These properties are no longer needed and can be removed to simplify the configuration. Removing unused properties helps in maintaining a cleaner and more efficient configuration.
# Select our ReplicatedQueueManager and JpaDatabaseTaskStore as the active implementations
quarkus.arc.selected-alternatives=io.a2a.extras.queuemanager.replicated.core.ReplicatedQueueManager,io.a2a.extras.taskstore.database.jpa.JpaDatabaseTaskStoreThere was a problem hiding this comment.
I have removed them, and you are telling me to remove them :-)
| # Configure PostgreSQL database (connection details will be provided by Testcontainers) | ||
| quarkus.datasource."a2a-java".db-kind=postgresql |
There was a problem hiding this comment.
These properties are no longer needed and can be removed to simplify the configuration. Removing unused properties helps in maintaining a cleaner and more efficient configuration.
# Select our ReplicatedQueueManager and JpaDatabaseTaskStore as the active implementations
quarkus.arc.selected-alternatives=io.a2a.extras.queuemanager.replicated.core.ReplicatedQueueManager,io.a2a.extras.taskstore.database.jpa.JpaDatabaseTaskStoreThere was a problem hiding this comment.
They are actually being removed!
| # Configure in-memory H2 database for testing | ||
| quarkus.datasource."a2a-java".db-kind=h2 |
There was a problem hiding this comment.
This property is no longer needed and can be removed to simplify the configuration. Removing unused properties helps in maintaining a cleaner and more efficient configuration.
# Select our ReplicatedQueueManager as the active implementation
quarkus.arc.selected-alternatives=io.a2a.extras.queuemanager.replicated.core.ReplicatedQueueManager,io.a2a.extras.taskstore.database.jpa.JpaDatabaseTaskStoreThere was a problem hiding this comment.
Yes, I am removing them
Upstream: #415