Skip to content

fix: Add missing extensions to Artifact and Message #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kabir merged 1 commit into from
Nov 3, 2025
Merged

fix: Add missing extensions to Artifact and Message #411

kabir merged 1 commit into from
Nov 3, 2025

Conversation

@fjuma
Copy link
Collaborator

@fjuma fjuma commented Oct 29, 2025 •
edited
Loading

Backporting #409 to 0.3.x

Depends on #412

@fjuma fjuma added the 0.3.x label Oct 29, 2025
@fjuma fjuma requested a review from kabir October 29, 2025 17:48
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 29, 2025

Summary of Changes

Hello @fjuma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new extensions field to both the Artifact record and the Message class, enhancing their ability to carry additional, unstructured string data. This change involves comprehensive updates to the data models, their builders, and associated utility and serialization logic to ensure seamless integration and proper handling of this new field across the system, including its mapping from gRPC structures. This is a backport of an existing feature to the 0.3.x branch.

Highlights

  • New 'extensions' field for Artifact: The Artifact record now includes a new List<String> extensions field, allowing for additional string-based metadata.
  • New 'extensions' field for Message: The Message class has been updated to include a new List<String> extensions field, providing similar extensibility for messages.
  • Updated Constructors and Builders: Both Artifact and Message constructors and their respective builder patterns have been modified to properly handle the initialization and manipulation of the new extensions field.
  • gRPC Integration: The ProtoUtils class has been updated to correctly map and transfer the extensions field when converting between gRPC Message and Artifact objects and their domain model counterparts.
  • Utility and Test Updates: Related utility methods in ArtifactUtils and serialization test cases in EventSerializationTest have been adjusted to accommodate the updated Artifact constructor signature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the extensions field to the Artifact and Message classes, propagating the change through constructors, builders, and serialization/deserialization logic in related utility and test files. The implementation is mostly sound, but I've pointed out a minor issue with a redundant assignment in the Artifact.Builder that should be corrected for code clarity.

@kabir kabir merged commit fd474fa into a2aproject:0.3.x Nov 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kabir kabir Awaiting requested review from kabir

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fjuma @kabir