-
Notifications
You must be signed in to change notification settings - Fork 110
fix: javadoc issues uncovered when using -Prelease #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses minor Javadoc issues that were uncovered when building with the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes Javadoc issues that were causing build failures with the -Prelease flag. The changes correctly address invalid HTML formatting in Javadoc comments. I have provided one suggestion to improve the conciseness of the documentation. Otherwise, the changes are accurate and the PR is good to merge.
| * <p> | ||
| * A task is active if: | ||
| * </p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this correctly fixes the Javadoc issue by separating the text from the <ul> list, the formatting is a bit verbose. For better readability and conciseness, you can combine the paragraph tag and its content onto a single line.
| * <p> | |
| * A task is active if: | |
| * </p> | |
| * <p>A task is active if:</p> |
No description provided.