Skip to content

fix: Filter benign stream errors in KafkaReplicationIntegrationTest a… #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fjuma merged 2 commits into from
Oct 28, 2025
Merged

fix: Filter benign stream errors in KafkaReplicationIntegrationTest a… #398

fjuma merged 2 commits into from
Oct 28, 2025

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Oct 28, 2025

…nd improve CI diagnostics

@kabir
fix: Filter benign stream errors in KafkaReplicationIntegrationTest a…
306bacc 
…nd improve CI diagnostics

  - Filter HTTP/2 stream cancellation errors in KafkaReplicationIntegrationTest (same fix as PR a2aproject#380)
  - Add surefire reports and build logs upload to build-and-test workflow
  - Enhance TCK workflow to capture test output, server logs, and compliance reports
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 28, 2025

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses test stability by filtering out benign HTTP/2 stream cancellation errors in KafkaReplicationIntegrationTest, which were causing misleading test failures. Additionally, it aims to significantly improve CI diagnostics by configuring workflows to upload more comprehensive reports and logs, facilitating quicker identification and resolution of build and test issues.

Highlights

  • Benign Error Filtering: Implemented a fix in KafkaReplicationIntegrationTest to filter out benign HTTP/2 stream cancellation errors, preventing false positives during testing. This involves adding a new helper method to identify and ignore these specific IOException types.
  • CI Diagnostics Improvement: Enhanced CI workflows by adding uploads for Surefire reports and build logs, and improving the TCK workflow to capture test output, server logs, and compliance reports for better debugging and analysis of test failures.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/build-and-test.yml
    • .github/workflows/run-tck.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request addresses a critical issue in the KafkaReplicationIntegrationTest by filtering out benign stream cancellation errors, which can occur during normal cleanup operations. This prevents these non-critical errors from being incorrectly flagged and improves the reliability of the test. Additionally, the pull request enhances CI diagnostics by adding surefire reports and build logs upload to the build-and-test workflow, and improves the TCK workflow to capture test output, server logs, and compliance reports. The changes to filter benign stream errors are crucial for preventing false positives during testing.

@fjuma fjuma merged commit 713120f into a2aproject:main Oct 28, 2025
9 checks passed
@kabir kabir deleted the failure-analysis branch October 28, 2025 14:03
kabir added a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@kabir
fix: Filter benign stream errors in KafkaReplicationIntegrationTest a… (
2052d5a 
a2aproject#398)

…nd improve CI diagnostics

- Filter HTTP/2 stream cancellation errors in
KafkaReplicationIntegrationTest (same fix as PR a2aproject#380)
- Add surefire reports and build logs upload to build-and-test workflow
- Enhance TCK workflow to capture test output, server logs, and
compliance reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjuma fjuma fjuma approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kabir @fjuma