Skip to content

fix: Update A2AException and A2AClientError so that they extend RuntimeException instead of IOException #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsavoie merged 1 commit into from
Oct 21, 2025
Merged

fix: Update A2AException and A2AClientError so that they extend RuntimeException instead of IOException #379

ehsavoie merged 1 commit into from
Oct 21, 2025

Conversation

@fjuma
Copy link
Collaborator

@fjuma fjuma commented Oct 20, 2025

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #320 🦕

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 20, 2025

Summary of Changes

Hello @fjuma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the exception handling within the io.a2a.spec package by modifying A2AClientError and A2AException to inherit from RuntimeException. This change transitions these custom exceptions from checked to unchecked, streamlining error propagation and reducing boilerplate try-catch blocks for callers, aligning with a common pattern for application-specific or unrecoverable errors.

Highlights

  • Exception Hierarchy Update: The A2AClientError class now extends RuntimeException instead of Exception, changing it from a checked to an unchecked exception.
  • Exception Hierarchy Update: The A2AException class now extends RuntimeException instead of IOException, also converting it to an unchecked exception. The corresponding java.io.IOException import has been removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 20, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly changes A2AException and A2AClientError to be unchecked exceptions by extending RuntimeException. This is a good move to simplify client code. Since this is a breaking API change, I recommend a follow-up to remove the now-redundant throws clauses from method signatures where these exceptions were thrown as checked exceptions (e.g., in A2A.getAgentCard(...)). Additionally, it would be beneficial to update the corresponding @throws Javadoc tags. To fully adhere to Conventional Commits for breaking changes, you might also consider using fix!: in your commit message.

@fjuma
Copy link
Collaborator Author

fjuma commented Oct 20, 2025

Code Review

This pull request correctly changes A2AException and A2AClientError to be unchecked exceptions by extending RuntimeException. This is a good move to simplify client code. Since this is a breaking API change, I recommend a follow-up to remove the now-redundant throws clauses from method signatures where these exceptions were thrown as checked exceptions (e.g., in A2A.getAgentCard(...)). Additionally, it would be beneficial to update the corresponding @throws Javadoc tags. To fully adhere to Conventional Commits for breaking changes, you might also consider using fix!: in your commit message.

@kabir @ehsavoie Do either of you have a strong preference on whether or not to remove the throws clauses now that we're switching to using RuntimeExceptions?

@kabir
Copy link
Collaborator

kabir commented Oct 20, 2025

@fjuma Not really. My initial thought is that keeping them in the throws clause is nice since it tells users what might happen. However, since that is not enforced, our milage might vary :-)

@ehsavoie ehsavoie merged commit dcbc1ad into a2aproject:main Oct 21, 2025
8 checks passed
@ehsavoie
Copy link
Collaborator

ehsavoie commented Oct 21, 2025

Thanks @fjuma

kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@fjuma @kabir
fix: Update A2AException and A2AClientError so that they extend Runti…
c71d458 
…meException instead of IOException (a2aproject#379)

# Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [x] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md).
- [x] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- Important Prefixes for
[release-please](https://github.com/googleapis/release-please):
- `fix:` which represents bug fixes, and correlates to a
[SemVer](https://semver.org/) patch.
- `feat:` represents a new feature, and correlates to a SemVer minor.
- `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking
change (indicated by the `!`) and will result in a SemVer major.
- [x] Ensure the tests pass
- [x] Appropriate READMEs were updated (if necessary)

Fixes a2aproject#320  🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kabir kabir kabir approved these changes

@ehsavoie ehsavoie ehsavoie approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feat]: Proposal to move to RuntimeExceptions from checked exceptions in the SDK

3 participants

@fjuma @kabir @ehsavoie