Skip to content

chore: upgrade build-and-test workflow to test Java 17 and 21 #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kabir merged 5 commits into from
Oct 2, 2025
Merged

chore: upgrade build-and-test workflow to test Java 17 and 21 #321

kabir merged 5 commits into from
Oct 2, 2025

Conversation

@Asymtode712
Copy link
Contributor

@Asymtode712 Asymtode712 commented Oct 1, 2025 •
edited by kabir
Loading

Description

  • Added matrix strategy to test against multiple Java versions (17, 21)
  • Dynamically sets JDK version in workflow steps using matrix variable
  • Ensures compatibility across different Java environments
image

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #313 🦕

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 1, 2025

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@Asymtode712
Copy link
Contributor Author

Asymtode712 commented Oct 1, 2025

@kabir @fjuma Please review this PR and merge it if it's good to go

fjuma
fjuma approved these changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @Asymtode712!

@fjuma fjuma requested a review from kabir October 1, 2025 15:28
@kabir
Copy link
Collaborator

kabir commented Oct 2, 2025

Thanks @Asymtode712! It looks good and passes CI. However, I messed up in the original issue and put 24 which should have been 25, which is the actual LTS version. Would you be able to update it?

@Asymtode712
Copy link
Contributor Author

Asymtode712 commented Oct 2, 2025

@kabir sure !!

@Asymtode712
Copy link
Contributor Author

Asymtode712 commented Oct 2, 2025

@kabir done with the changes, kindly review

@kabir
Copy link
Collaborator

kabir commented Oct 2, 2025

Sorry, @Asymtode712 it doesn't seem to me my day :-D

We actually need to leave 25 out since we don't have a Quarkus/Vert.X version yet that supports Java 25. We're tracking that here #315. That explains the test failures.

Would you be able to remove 25 from the matrix?

@Asymtode712
Copy link
Contributor Author

Asymtode712 commented Oct 2, 2025

@kabir sure np

@Asymtode712
Copy link
Contributor Author

Asymtode712 commented Oct 2, 2025

@kabir done with the change, please review

@kabir kabir changed the title chore: upgrade build-and-test workflow to test Java 17, 21, and 24 chore: upgrade build-and-test workflow to test Java 17 and 21 Oct 2, 2025
@kabir kabir merged commit b976bcf into a2aproject:main Oct 2, 2025
9 checks passed
@kabir
Copy link
Collaborator

kabir commented Oct 2, 2025

Thank you @Asymtode712 !

kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
@Asymtode712 @kabir
chore: upgrade build-and-test workflow to test Java 17 and 21 (a2apro…
6bd6ef0 
…ject#321)

# Description
- Added matrix strategy to test against multiple Java versions (17, 21)
- Dynamically sets JDK version in workflow steps using matrix variable
- Ensures compatibility across different Java environments
<img width="612" height="355" alt="image"
src="proxy.php?url=https%3A%2F%2Fgithub.com%2Fa2aproject%2Fa2a-java%2Fpull%2F%3Ca+href%3D"https://github.com/user-attachments/assets/67345f39-87b6-472f-b144-d6480759628f">https://github.com/user-attachments/assets/67345f39-87b6-472f-b144-d6480759628f"
/>


Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [X] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md).
- [X] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- [X] Ensure the tests pass

Fixes a2aproject#313  🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjuma fjuma fjuma approved these changes

@kabir kabir Awaiting requested review from kabir

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[chore]: Upgrade the build-and-test.yml GH Actions workflow to test more Java versions

3 participants

@Asymtode712 @kabir @fjuma