chore: Upgrade to Quarkus 3.28.1 #316
Conversation
Summary of ChangesHello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine maintenance update by upgrading the project's Quarkus platform dependency. This ensures the application benefits from the latest features, performance improvements, and security fixes provided by the newer Quarkus version, aligning the project with recent framework advancements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request upgrades the Quarkus platform version to 3.28.1. While keeping dependencies current is important, the approach taken is risky as it only updates the platform version while leaving several related, manually-overridden dependencies untouched. This can lead to version conflicts and runtime issues. My review provides a comment on this risk with a recommendation for a safer upgrade strategy.
| <protobuf.version>4.31.1</protobuf.version> | ||
| <protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version> | ||
| <quarkus.platform.version>3.24.5</quarkus.platform.version> | ||
| <quarkus.platform.version>3.28.1</quarkus.platform.version> |
There was a problem hiding this comment.
This dependency upgrade is potentially unsafe. The versions of several dependencies also managed by the quarkus-bom are hardcoded in this file, for example rest-assured (line 64), jackson (line 51), junit (line 56), and slf4j (line 65). These pinned versions may be incompatible with the new Quarkus version 3.28.1, which can lead to subtle runtime bugs or build failures. For a safe and maintainable dependency management strategy, it is recommended to remove these overrides and rely on the versions curated in the Quarkus BOM.
No description provided.