fix!: Rename pushNotification to pushNotificationConfig (#286) #290

powmax-commits · 2025-09-22T19:42:27Z

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Follow the CONTRIBUTING Guide.
Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
- Important Prefixes for release-please:
  - fix: which represents bug fixes, and correlates to a SemVer patch.
  - feat: represents a new feature, and correlates to a SemVer minor.
  - feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
Ensure the tests pass
Appropriate READMEs were updated (if necessary)

Fixes #286 🦕

gemini-code-assist · 2025-09-22T19:42:46Z

Summary of Changes

Hello @powmax-commits, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant renaming operation, changing all instances of pushNotification to pushNotificationConfig. This modification spans the Protobuf schema, generated Java gRPC code, and the core client and server-side logic, ensuring consistency and clarity in how push notification configurations are referenced and handled. The change is categorized as a breaking fix, indicating an important update to the API.

Highlights

API Renaming: The pushNotification field and its related methods have been consistently renamed to pushNotificationConfig across the codebase for improved clarity.
Protobuf Schema Update: The underlying Protobuf definition (a2a.proto) for SendMessageConfiguration was updated to reflect this rename, changing push_notification to push_notification_config.
Breaking Change: This rename is explicitly marked as a breaking change (fix!) due to its impact on the API and wire format, necessitating updates in client and server implementations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a breaking change by renaming pushNotification to pushNotificationConfig for consistency. The changes are applied correctly across all relevant files, including the protobuf definition, generated code, and business logic. The refactoring is well-executed, and I have no further suggestions.

fjuma · 2025-09-22T19:54:17Z

spec-grpc/src/main/java/io/a2a/grpc/A2A.java

      "le/api/field_behavior.proto\032\033google/prot" +
      "obuf/empty.proto\032\034google/protobuf/struct" +
      ".proto\032\037google/protobuf/timestamp.proto\"" +
-      "\236\001\n\030SendMessageConfiguration\022\035\n\025accepted" +


We automatically generate this file using buf generate from the .proto specification file from the a2a repo. We can remove these changes from this PR for now and once updated upstream, we'll incorporate the changes here.

fjuma · 2025-09-22T19:54:53Z

spec-grpc/src/main/java/io/a2a/grpc/SendMessageConfiguration.java


-  public static final int PUSH_NOTIFICATION_FIELD_NUMBER = 2;
-  private io.a2a.grpc.PushNotificationConfig pushNotification_;
+  public static final int PUSH_NOTIFICATION_CONFIG_FIELD_NUMBER = 2;


Same here, since we auto-generate this file, we can remove these changes for now.

fjuma · 2025-09-22T19:55:17Z

spec-grpc/src/main/java/io/a2a/grpc/SendMessageConfigurationOrBuilder.java

   *
-   * <code>.a2a.v1.PushNotificationConfig push_notification = 2;</code>
-   * @return Whether the pushNotification field is set.
+   * <code>.a2a.v1.PushNotificationConfig push_notification_config = 2;</code>


Same here, this is an auto-generated file.

fjuma · 2025-09-22T19:56:11Z

spec-grpc/src/main/proto/a2a.proto

  repeated string accepted_output_modes = 1;
  // A configuration of a webhook that can be used to receive updates
-  PushNotificationConfig push_notification = 2;
+  PushNotificationConfig push_notification_config = 2;


Would you be able to raise an issue in https://github.com/a2aproject/A2A and submit a PR against that project with this change? (that's where we get this .proto file from and use it to generate the files).

Pending, will backlink here.

Issue: a2aproject/A2A#1091

Great, thanks very much!

No problem - PR here: a2aproject/A2A#1092

fjuma

Good catch, @powmax-commits!

I've just added some small comments here to remove the changes from the auto-generated gRPC files for now and submit a PR against https://github.com/a2aproject/A2A/issues to correct the gRPC .proto spec file. Once that change is included in a release, we'll update the generated files here accordingly.

Thanks very much!

powmax-commits · 2025-09-22T20:06:37Z

Thanks for taking a look @fjuma - I'll address both and update the request.

…) (a2aproject#290) # Description Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [X] Follow the [`CONTRIBUTING` Guide](../CONTRIBUTING.md). - [X] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [x] Ensure the tests pass - [X] Appropriate READMEs were updated (if necessary) Fixes a2aproject#286 🦕

gemini-code-assist bot reviewed Sep 22, 2025

View reviewed changes

fjuma reviewed Sep 22, 2025

View reviewed changes

fjuma requested changes Sep 22, 2025

View reviewed changes

fix!: Rename pushNotification to pushNotificationConfig (a2aproject#286)

2b7730d

powmax-commits force-pushed the main branch from 6349afd to 2b7730d Compare September 22, 2025 20:48

powmax-commits requested a review from fjuma September 22, 2025 20:55

powmax-commits mentioned this pull request Sep 22, 2025

[Bug]: SendMessageConfiguration::push_notification should be push_notitifcation_config a2aproject/A2A#1091

Closed

1 task

fjuma approved these changes Sep 22, 2025

View reviewed changes

fjuma requested a review from kabir September 22, 2025 21:17

powmax-commits mentioned this pull request Sep 22, 2025

fix(grpc): Rename push_notification to push_notification_config (#1091) a2aproject/A2A#1092

Closed

kabir approved these changes Sep 23, 2025

View reviewed changes

fjuma merged commit a201168 into a2aproject:main Sep 23, 2025
4 checks passed

fix!: Rename pushNotification to pushNotificationConfig (#286) #290

fix!: Rename pushNotification to pushNotificationConfig (#286) #290

Uh oh!

Conversation

powmax-commits commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

gemini-code-assist bot commented Sep 22, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fjuma Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fjuma left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

powmax-commits commented Sep 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

powmax-commits commented Sep 22, 2025 •

edited

Loading

fjuma Sep 22, 2025 •

edited

Loading

fjuma left a comment •

edited

Loading