Skip to content

Fix Error 1001: JavaScript profiling failed #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmetais merged 2 commits into from
Oct 6, 2016
Merged

Fix Error 1001: JavaScript profiling failed #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f354cf
Clarify cookies
gmetais Sep 21, 2016
d4eac73
Fix for Error 1001: JavaScript profiling failed
gmetais Oct 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion front/src/views/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ <h2 class="promess">Online test to help speeding up <b>heavy</b> web pages</h2>
Cookie
<span class="settingsTooltip">
<span class="icon-question"></span>
<div><b>Cookie</b><br><br>Adds a cookie on the main domain.<br><br>Example: "bar=foo;domain=url"</div>
<div><b>Cookie</b><br><br>Adds a single cookie (on the main domain if you don't provide the domain).<br><br>Example: "bar=foo;domain=.something.com"</div>
</span>
</div>
<div><input type="text" name="cookie" ng-model="settings.cookie" /></div>
Expand Down
16 changes: 8 additions & 8 deletions lib/tools/phantomas/custom_modules/modules/domQYLT/domQYLT.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ exports.module = function(phantomas) {
});

}, function(result, args) {
var id = args[0];
var id = args ? '#' + args[0] : undefined;

querySpy('id', '#' + id, 'getElementById', '#document', (result === null));
querySpy('id', id, 'getElementById', '#document', (result === null));

var moreData = {
resultsNumber : (result === null) ? 0 : 1
Expand Down Expand Up @@ -74,10 +74,10 @@ exports.module = function(phantomas) {
function selectorClassNameAfter(result, args) {
/*jshint validthis: true */

var className = args[0];
var className = args ? '.' + args[0] : undefined;
var context = phantomas.getDOMPath(this);

querySpy('class', '.' + className, 'getElementsByClassName', context, (result.length === 0));
querySpy('class', className, 'getElementsByClassName', context, (result.length === 0));

var moreData = {
resultsNumber : (result && result.length > 0) ? result.length : 0
Expand Down Expand Up @@ -113,10 +113,10 @@ exports.module = function(phantomas) {
function selectorTagNameSpyAfter(result, args) {
/*jshint validthis: true */

var tagName = args[0];
var tagName = args ? args[0].toLowerCase() : undefined;
var context = phantomas.getDOMPath(this);

querySpy('tag name', tagName.toLowerCase(), 'getElementsByTagName', context, (result.length === 0));
querySpy('tag name', tagName, 'getElementsByTagName', context, (result.length === 0));

var moreData = {
resultsNumber : (result && result.length > 0) ? result.length : 0
Expand Down Expand Up @@ -156,7 +156,7 @@ exports.module = function(phantomas) {
function selectorQuerySpyAfter(result, args) {
/*jshint validthis: true */

var selector = args[0];
var selector = args ? args[0] : undefined;
var context = phantomas.getDOMPath(this);

querySpy('selector', selector, 'querySelectorAll', context, (!result || result.length === 0));
Expand Down Expand Up @@ -189,7 +189,7 @@ exports.module = function(phantomas) {
function selectorAllQuerySpryAfter(result, args) {
/*jshint validthis: true */

var selector = args[0];
var selector = args ? args[0] : undefined;
var context = phantomas.getDOMPath(this);

querySpy('selector', selector, 'querySelectorAll', context, (!result || result.length === 0));
Expand Down
15 changes: 15 additions & 0 deletions test/core/indexTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,21 @@ describe('index.js', function() {
});
});

it('should succeed on try-catch.html', function(done) {
this.timeout(15000);

var url = 'http://localhost:8388/try-catch.html';

ylt(url)
.then(function(data) {
data.toolsResults.phantomas.metrics.should.have.a.property('jsErrors').that.equals(0);
done();
}).fail(function(err) {
console.log.restore();
done(err);
});
});

it('should take a screenshot', function(done) {
this.timeout(15000);

Expand Down
21 changes: 21 additions & 0 deletions test/www/try-catch.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<html>
<head>
<title>Testing getElementById with a try catch statement</title>
</head>
<body>
<div id="foo">Some text</div>
<script>
try {
document.getElementById(undefined);
document.getElementsByClassName(undefined);
document.getElementsByTagName(undefined);

} catch(err) {
console.log('Error found: ' + err);
throw new Error("I detect an error!");
}

document.getElementById('foo');
</script>
</body>
</html>