[WIP] Generate additional mime types on upload#151
Closed
adamsilverstein wants to merge 14 commits into
Closed
Conversation
Co-authored-by: Crisoforo Gaspar Hernández <hello@crisoforo.com>
# Conflicts: # modules/images/webp-uploads/load.php
Member
|
@adamsilverstein We need to be careful here to not introduce this logic entirely on the server-side, to avoid timeouts. This relates to the enhancements from https://core.trac.wordpress.org/ticket/40439 - the additional sizes in the other format have to somehow be kicked off from the client-side, so that the server can take care of them through individual requests. |
Member
|
@adamsilverstein Do we still need this PR to be open? I'm thinking it's probably somewhat of a duplicate of #147 which is being worked on now. |
Member
Author
|
Closing, this was an experimental PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
image_editor_output_formatsthat returns the output formats and their order. The first type is used as the default output formatimage_editor_output_formatfilter applies for the first mime type, which also creates a full sized image if not the dame mime type as the uploaded image.Usage
By default, this code will generate WebP and jpeg sub sizes for every uploaded image, with WebP as the default.
Fixes #
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.