Add TypeScript parser tests for shouldSkipReference#76611
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 8.76 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 57261fa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23257871350
|
ciampo
approved these changes
Mar 18, 2026
Contributor
ciampo
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thank you for the follow up!
Since shouldSkipReference is shared across the other no-dom-globals-* rules, should we add TS-parser tests to those tests too? Not a blocker, just a consideration.
Member
Author
Done. Thank you |
adamsilverstein
pushed a commit
that referenced
this pull request
Mar 31, 2026
Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #76508.
Add TypeScript parser tests for the
shouldSkipReferenceutility in theno-dom-globals-*rules.Why?
#76508 added
TSTypeReference,TSInterfaceHeritage, andTSTypeQueryto the skip list inshouldSkipReference, but the tests used the default parser which doesn't produce TS AST nodes. These tests use@typescript-eslint/parserto verify the skip conditions actually work.How?
Added a separate
RuleTesterinstance configured with@typescript-eslint/parserinno-dom-globals-in-module-scopetests:const el: HTMLElement(TSTypeReference),interface MyEl extends HTMLElement(TSInterfaceHeritage),type Win = typeof window(TSTypeQuery)const width = window.innerWidth— value-level usage is still flagged in TS filesTesting Instructions
npm run test:unit -- packages/eslint-plugin/rules/__tests__/no-dom-globals-in-module-scope.jsScreenshots or screencast
N/A
Use of AI Tools
This PR was authored with Claude Code.