Create a reverse map for faster itemBlock lookups#73930
Merged
Conversation
|
Size Change: +15 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0b711b4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20199102920
|
Mamaduka
reviewed
Dec 12, 2025
Member
There was a problem hiding this comment.
With all the "mocking," there's probably little value in unit tests here, IMO. I think we have decent e2e test coverage. If something is missing, let's try to improve it.
Member
Author
There was a problem hiding this comment.
do these hooks have coverage already (where)? do we have test coverage reports that tell us what is or isn't covered?
Member
There was a problem hiding this comment.
Usually, it's preferred to write e2e tests, unless the utility methods are complex. Besides components and data packages, you won't see a lot of unit tests.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Dec 15, 2025
Member
Mamaduka
left a comment
There was a problem hiding this comment.
Thank you, @adamsilverstein!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Improves performance of useBlockComments when there are many notes by replacing an O(n²) nested loop with an O(n) direct lookup. Previously, the code used Object.keys().find() to locate block client IDs for each comment thread, resulting in a search through all blocks for every thread. This change creates a reverse mapping (commentIdToBlockClientId) from comment IDs to block client IDs once, then performs constant-time lookups instead.
Part of #71668