[Block Editor]: Update text align toolbar control label#47119
Merged
Conversation
|
Size Change: +52 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 555e04e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3909758854
|
t-hamano
approved these changes
Jan 13, 2023
Contributor
t-hamano
left a comment
There was a problem hiding this comment.
LGTM 👍
Enable "Show button text labels":
I have used the NVDA screen reader and it appears to be fine (this video contains audio):
a11y.mp4
alexstine
approved these changes
Jan 13, 2023
Contributor
alexstine
left a comment
There was a problem hiding this comment.
@ntsekouras Thanks for this enhancement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #46683
AlignmentControltoolbar control is used from blocks to change thealign textsetting. If a block support bothalignandalign text, the label is the same for both(Align) which creates a11y problems.This PR updates the label of the align text control to
Align text.Screenshots or screencast
Screen.Recording.2023-01-12.at.6.52.14.PM.mov