Skip to content

[Coordinated Graphics] ScrollingTreeCoordinated: Consolidate findEventListenerRegionTypes and collectDescendantLayersAtPoint#69429

Open
fujii wants to merge 1 commit into
WebKit:mainfrom
fujii:wa
Open

[Coordinated Graphics] ScrollingTreeCoordinated: Consolidate findEventListenerRegionTypes and collectDescendantLayersAtPoint#69429
fujii wants to merge 1 commit into
WebKit:mainfrom
fujii:wa

Conversation

@fujii

@fujii fujii commented Jul 15, 2026 •
edited by webkit-early-warning-system
Loading

Copy link
Copy Markdown
Contributor

02d83f4

[Coordinated Graphics] ScrollingTreeCoordinated: Consolidate findEventListenerRegionTypes and collectDescendantLayersAtPoint
https://bugs.webkit.org/show_bug.cgi?id=319437

Reviewed by NOBODY (OOPS!).

315799@main added findEventListenerRegionTypes() in ScrollingTreeCoordinated.cpp
by copying collectDescendantLayersAtPoint() in the file. They can be consolidated.
Removed them, and added traverseDescendantLayersAtPoint().

* Source/WebCore/page/scrolling/coordinated/ScrollingTreeCoordinated.cpp:
(WebCore::traverseDescendantLayersAtPoint):
(WebCore::ScrollingTreeCoordinated::scrollingNodeForPoint):
(WebCore::ScrollingTreeCoordinated::eventListenerRegionTypesForPoint const):
(WebCore::collectDescendantLayersAtPoint): Deleted.
(WebCore::findEventListenerRegionTypes): Deleted.

02d83f4

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 ios-safer-cpp ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 api-gtk
✅ 🛠 vision-sim ⏳ 🧪 mac-intel-wk2 ⏳ 🛠 playstation
✅ 🧪 vision-wk2 ⏳ 🛠 mac-safer-cpp
✅ 🛠 tv ✅ 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@fujii
[Coordinated Graphics] ScrollingTreeCoordinated: Consolidate findEven…
02d83f4 
…tListenerRegionTypes and collectDescendantLayersAtPoint

https://bugs.webkit.org/show_bug.cgi?id=319437

Reviewed by NOBODY (OOPS!).

315799@main added findEventListenerRegionTypes() in ScrollingTreeCoordinated.cpp
by copying collectDescendantLayersAtPoint() in the file. They can be consolidated.
Removed them, and added traverseDescendantLayersAtPoint().

* Source/WebCore/page/scrolling/coordinated/ScrollingTreeCoordinated.cpp:
(WebCore::traverseDescendantLayersAtPoint):
(WebCore::ScrollingTreeCoordinated::scrollingNodeForPoint):
(WebCore::ScrollingTreeCoordinated::eventListenerRegionTypesForPoint const):
(WebCore::collectDescendantLayersAtPoint): Deleted.
(WebCore::findEventListenerRegionTypes): Deleted.
@fujii fujii requested a review from magomez as a code owner July 15, 2026 00:41
@fujii fujii self-assigned this Jul 15, 2026
@webkit-early-warning-system

webkit-early-warning-system commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on current version of this PR (hash 02d83f4)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 ios-safer-cpp ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 api-gtk
✅ 🛠 vision-sim ⏳ 🧪 mac-intel-wk2 ⏳ 🛠 playstation
✅ 🧪 vision-wk2 ⏳ 🛠 mac-safer-cpp
✅ 🛠 tv ✅ 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@fujii fujii added the WebKitGTK Bugs related to the Gtk API layer. label Jul 15, 2026
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@magomez magomez Awaiting requested review from magomez magomez is a code owner

Assignees

@fujii fujii

Labels

merging-blocked Applied to prevent a change from being merged WebKitGTK Bugs related to the Gtk API layer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fujii @webkit-early-warning-system @webkit-ews-buildbot