Fill in missing case of implicit backpressure when donut-wrapping - #697
Open
lukewagner wants to merge 1 commit into
Open
Fill in missing case of implicit backpressure when donut-wrapping#697lukewagner wants to merge 1 commit into
lukewagner wants to merge 1 commit into
Conversation
…r recursive sync-to-async calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auditing the validity of Component Invariant #3 surfaced that this invariant can be broken in donut-wrapping scenarios. (IIUC, donut wrapping is not-yet-implemented (and only recently re-enabled at the spec-level in #650), so this doesn't affect existing implementations.) The scenario is a parent-to-child-to-parent call where the outer parent call is expecting LIFO sync execution but the inner parent call is async-typed (which can block and break LIFO) and the solution is simply to exert backpressure at the attempted inner parent call. The PR has more details.