docs(server-core): add README with package overview and usage example#1331
docs(server-core): add README with package overview and usage example#1331nuthalapativarun wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 7fb4776 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded a comprehensive README for the ChangesPackage Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/server-core/README.md`:
- Around line 68-77: Update the observability handler names in the README to
match the actual exports: replace handleGetTraces with getTracesHandler,
handleGetTraceById with getTraceByIdHandler, and handleGetObservabilityStatus
with getObservabilityStatusHandler so the listed observability handlers match
the exported symbols (verify the surrounding list of handlers like
handleGenerateText, handleGetWorkflows, handleListTools,
handleListMemoryConversations, handleGetLogs remains unchanged).
- Around line 79-106: Update the README to use the actual exported registry/type
and helper names: replace any references to "McpRegistry" and "A2ARegistry" with
"MCPServerRegistry" and "A2AServerRegistry", and update helper function names to
"listMcpServers" / "lookupMcpServer" and "listA2AServers" / "lookupA2AServer"
(instead of the generic "buildMcpRoutePaths" or "resolveAgentCard" names if
present), so the README matches the real public exports.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 703a8db6-9cc5-43b7-89ad-d81c10c349e6
📒 Files selected for processing (2)
.changeset/server-core-readme.mdpackages/server-core/README.md
There was a problem hiding this comment.
2 issues found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PR Checklist
<type>(<scope>): <description>pnpm changesetWhat is the current behavior?
@voltagent/server-corehas no README.md.What is the new behavior?
A README documents the package purpose, key exports, and a minimal TypeScript usage example.
fixes #1330
Notes for reviewers
Content is derived from the package source. Style mirrors packages/core/README.md.
Summary by cubic
Added a README for
@voltagent/server-corewith an overview, key exports, and a minimal example for building a custom server adapter. Addresses #1330 by documenting package purpose, usage, the./edgeentry, and correcting handler and registry names for accuracy.Written for commit 7fb4776. Summary will update on new commits.
Summary by CodeRabbit