Raise the gutter DigitCount limit from 12 to 24 - #4
Open
TetzkatLipHoka wants to merge 1 commit into
Open
Conversation
SetDigitCount clamped to MinMax(Value, 2, 12), a limit from the time when
the line number band could only ever show a line number. With
OnGutterGetText the band holds arbitrary text - hex offsets, symbol names -
and gbkLineNumbers.RealWidth is computed from DigitCount, not from the text
the event returns, so anything longer is clipped. A 16 digit offset needs
DigitCount = 16.
Nothing in the class depends on the value: it only feeds a Max(), a
Format('%*d') and one multiplication. The limit is raised rather than
removed so that a typo cannot blow up the gutter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetDigitCount clamped to MinMax(Value, 2, 12), a limit from the time when
the line number band could only ever show a line number. With
OnGutterGetText the band holds arbitrary text - hex offsets, symbol names -
and gbkLineNumbers.RealWidth is computed from DigitCount, not from the text
the event returns, so anything longer is clipped. A 16 digit offset needs
DigitCount = 16.
Nothing in the class depends on the value: it only feeds a Max(), a
Format('%*d') and one multiplication. The limit is raised rather than
removed so that a typo cannot blow up the gutter.
Built with 13.1.
🤖 Generated with Claude Code