Skip to content

fix: networkprefab upgrade with formerlyserializedas attribute - #619

Merged
mattwalsh-unity merged 2 commits into
release/0.1.0from
fix/networkprefab-upgrade
Mar 15, 2021
Merged

fix: networkprefab upgrade with formerlyserializedas attribute#619
mattwalsh-unity merged 2 commits into
release/0.1.0from
fix/networkprefab-upgrade

Conversation

@LukeStampfli

Copy link
Copy Markdown
Contributor

This fixes a bug which clears the NetworkPrefab list in NetworkManager when upgrading from the MLAPI version before our name changes.

@mattwalsh-unity
mattwalsh-unity merged commit 9691b49 into release/0.1.0 Mar 15, 2021
@mattwalsh-unity
mattwalsh-unity deleted the fix/networkprefab-upgrade branch March 15, 2021 15:57
@0xFA11

0xFA11 commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

@mattwalsh-unity @LukeStampfli — I think this PR went in so quickly.
we renamed lots of other classes and fields as well but never put [FormerlySerializedAs] attributes on newly named fields.
we intentionally broke API and serialization once for all, for the greater good.
I personally think we should not have these kinds of redirects, [Obsolete], [FormerlySerializedAs] or other stuff pointing pre-evo MLAPI.
I believe we should at least have a conversation about this, as in this case, I wasn't entirely happy with this change.
I might be convinced in that discussion but ¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants