Skip to content

fix: reader.ReadRotationPacked() "w" reconstruction - #332

Merged
TwoTenPvP merged 1 commit into
Unity-Technologies:masterfrom
rivFox:patch-2
May 1, 2020
Merged

fix: reader.ReadRotationPacked() "w" reconstruction#332
TwoTenPvP merged 1 commit into
Unity-Technologies:masterfrom
rivFox:patch-2

Conversation

@rivFox

@rivFox rivFox commented May 1, 2020

Copy link
Copy Markdown
Contributor

The correct formula to reconstruct w is

w = sqrt( 1 - x^2 - y^2 - z^2 )

but in code was

w = sqrt(1 - x^2 + y^2 - z^2)

@rivFox
rivFox requested a review from TwoTenPvP as a code owner May 1, 2020 01:14
@TwoTenPvP TwoTenPvP changed the title Fix reader.ReadRotationPacked() "w" reconstruction fix: reader.ReadRotationPacked() "w" reconstruction May 1, 2020
@TwoTenPvP
TwoTenPvP merged commit 310999e into Unity-Technologies:master May 1, 2020
@MidLevel-Bot

Copy link
Copy Markdown

This pull request is included in version 11.11.1

The release is available to download on GitHub release or in the MLAPI Installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants